Skip to content

8320536: problemlist failing serviceability/attach/ConcAttachTest.java test on macosx #16772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

plummercj
Copy link
Contributor

@plummercj plummercj commented Nov 21, 2023

Problemlisting ConcAttachTest.java on OSX (it's already problem listed on linux and doesn't get run on Windows). This one test seems to be causing all the issues with attach and dcmd tests described in JDK-8318866, so if we problem list it we should stop seeing the other test failures.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8320536: problemlist failing serviceability/attach/ConcAttachTest.java test on macosx (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16772/head:pull/16772
$ git checkout pull/16772

Update a local copy of the PR:
$ git checkout pull/16772
$ git pull https://git.openjdk.org/jdk.git pull/16772/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16772

View PR using the GUI difftool:
$ git pr show -t 16772

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16772.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 21, 2023

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8320536 8320536: problemlist failing serviceability/attach/ConcAttachTest.java test on macosx Nov 21, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 21, 2023
@openjdk
Copy link

openjdk bot commented Nov 21, 2023

@plummercj To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@plummercj
Copy link
Contributor Author

/label serviceability

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Nov 21, 2023
@openjdk
Copy link

openjdk bot commented Nov 21, 2023

@plummercj
The serviceability label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Nov 21, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 21, 2023

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320536: problemlist failing serviceability/attach/ConcAttachTest.java test on macosx

Reviewed-by: amenkov, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • d1af748: 8309067: gtest/AsyncLogGtest.java fails again in stderrOutput_vm

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 21, 2023
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@plummercj
Copy link
Contributor Author

Thank you Alex and David!

/integrate

@openjdk
Copy link

openjdk bot commented Nov 22, 2023

Going to push as commit 572b14a.
Since your change was applied there have been 19 commits pushed to the master branch:

  • 30462f9: 8318986: Improve GenericWaitBarrier performance
  • 407cdd4: 8320207: doclet incorrectly chooses code font for a See Also link
  • 1629a90: 8320331: G1 Full GC Heap verification relies on metadata not reset before verification
  • 93bdc2a: 8306055: Add a built-in Catalog to JDK XML module
  • a4bd9e4: 8319440: RISC-V: jdk can't be built with clang due to register keyword
  • 524da14: 8320418: PPC64: invokevfinal_helper duplicates code to handle ResolvedMethodEntry
  • 5d4a54b: 8319449: compiler/print/CompileCommandPrintMemStat.java fails on Graal
  • 35526d0: 8257076: os::scan_pages is empty on all platforms
  • 25cebe8: 8317799: AIX PPC64: FFI symbol lookup doesn't find symbols
  • c39d001: 8319137: release _object in ObjectMonitor dtor to avoid races
  • ... and 9 more: https://git.openjdk.org/jdk/compare/e47cf611c9490225e50a548787cbba66ab147058...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 22, 2023
@openjdk openjdk bot closed this Nov 22, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 22, 2023
@openjdk
Copy link

openjdk bot commented Nov 22, 2023

@plummercj Pushed as commit 572b14a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants