-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8320536: problemlist failing serviceability/attach/ConcAttachTest.java test on macosx #16772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into |
@plummercj To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/label serviceability |
@plummercj |
@plummercj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thank you Alex and David! /integrate |
Going to push as commit 572b14a.
Your commit was automatically rebased without conflicts. |
@plummercj Pushed as commit 572b14a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Problemlisting ConcAttachTest.java on OSX (it's already problem listed on linux and doesn't get run on Windows). This one test seems to be causing all the issues with attach and dcmd tests described in JDK-8318866, so if we problem list it we should stop seeing the other test failures.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16772/head:pull/16772
$ git checkout pull/16772
Update a local copy of the PR:
$ git checkout pull/16772
$ git pull https://git.openjdk.org/jdk.git pull/16772/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 16772
View PR using the GUI difftool:
$ git pr show -t 16772
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16772.diff
Webrev
Link to Webrev Comment