8320057: [macos14] javax/swing/JToolTip/4846413/bug4846413.java: Tooltip has not been found!#16776
8320057: [macos14] javax/swing/JToolTip/4846413/bug4846413.java: Tooltip has not been found!#16776prsadhuk wants to merge 2 commits intoopenjdk:masterfrom
Conversation
…tip has not been found!
|
👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into |
…tip has not been found!
|
I don't think this is a good idea. We aren't interested in just making the test "pass". |
| if (System.getProperty("os.name").contains("OS X")) { | ||
| String version = System.getProperty("os.version", ""); | ||
| if (version.startsWith("14.")) { | ||
| robot.mouseMove(movePoint.x, movePoint.y); |
There was a problem hiding this comment.
Adding to Phil's point, version specific test fixes would require to be removed and/or reworked if the issue gets fixed on latest macOS update.
|
@prsadhuk @honkar-jdk @prrace is it ongoing next 24 hours? |
@victordyakov The test fix consists of macOS version specific fix - adding an extra mouse event. But since we are trying find the root cause behind the issue and it might end up being reported as Apple Bug #16776 (comment), I believe this is not being targeted for tomorrow. |
Test failing on macos14 citing "ToolTip not found"...Investigation shows that the mouse is not moved when invoked 1st time to desired location on screen causing tooltip to not show...However, subsequent runs of the same test without any change causes it to pass every time.
Workaround is proposed to check if running on 14.x, then invoke a dummy mouse movement to same location which causes the test to pass for several iterations in macos14 environment.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16776/head:pull/16776$ git checkout pull/16776Update a local copy of the PR:
$ git checkout pull/16776$ git pull https://git.openjdk.org/jdk.git pull/16776/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 16776View PR using the GUI difftool:
$ git pr show -t 16776Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16776.diff
Webrev
Link to Webrev Comment