Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320057: [macos14] javax/swing/JToolTip/4846413/bug4846413.java: Tooltip has not been found! #16776

Closed
wants to merge 2 commits into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Nov 22, 2023

Test failing on macos14 citing "ToolTip not found"...Investigation shows that the mouse is not moved when invoked 1st time to desired location on screen causing tooltip to not show...However, subsequent runs of the same test without any change causes it to pass every time.
Workaround is proposed to check if running on 14.x, then invoke a dummy mouse movement to same location which causes the test to pass for several iterations in macos14 environment.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8320057: [macos14] javax/swing/JToolTip/4846413/bug4846413.java: Tooltip has not been found! (Bug - P4) ⚠️ Issue is not open.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16776/head:pull/16776
$ git checkout pull/16776

Update a local copy of the PR:
$ git checkout pull/16776
$ git pull https://git.openjdk.org/jdk.git pull/16776/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16776

View PR using the GUI difftool:
$ git pr show -t 16776

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16776.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 22, 2023

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 22, 2023

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Nov 22, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 22, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 22, 2023

Webrevs

@prrace
Copy link
Contributor

prrace commented Nov 22, 2023

I don't think this is a good idea. We aren't interested in just making the test "pass".
We need to understand what changed. If necessary it could end up in a bug report to Apple.

Comment on lines +76 to +79
if (System.getProperty("os.name").contains("OS X")) {
String version = System.getProperty("os.version", "");
if (version.startsWith("14.")) {
robot.mouseMove(movePoint.x, movePoint.y);
Copy link
Contributor

@honkar-jdk honkar-jdk Nov 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding to Phil's point, version specific test fixes would require to be removed and/or reworked if the issue gets fixed on latest macOS update.

@victordyakov
Copy link

@prsadhuk @honkar-jdk @prrace is it ongoing next 24 hours?

@honkar-jdk
Copy link
Contributor

honkar-jdk commented Dec 6, 2023

@prsadhuk @honkar-jdk @prrace is it ongoing next 24 hours?

@victordyakov The test fix consists of macOS version specific fix - adding an extra mouse event. But since we are trying find the root cause behind the issue and it might end up being reported as Apple Bug #16776 (comment), I believe this is not being targeted for tomorrow.

@prsadhuk prsadhuk closed this Dec 14, 2023
@prsadhuk prsadhuk deleted the JDK-8320057 branch December 14, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

4 participants