-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8320057: [macos14] javax/swing/JToolTip/4846413/bug4846413.java: Tooltip has not been found! #16776
Conversation
…tip has not been found!
👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into |
…tip has not been found!
I don't think this is a good idea. We aren't interested in just making the test "pass". |
if (System.getProperty("os.name").contains("OS X")) { | ||
String version = System.getProperty("os.version", ""); | ||
if (version.startsWith("14.")) { | ||
robot.mouseMove(movePoint.x, movePoint.y); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding to Phil's point, version specific test fixes would require to be removed and/or reworked if the issue gets fixed on latest macOS update.
@prsadhuk @honkar-jdk @prrace is it ongoing next 24 hours? |
@victordyakov The test fix consists of macOS version specific fix - adding an extra mouse event. But since we are trying find the root cause behind the issue and it might end up being reported as Apple Bug #16776 (comment), I believe this is not being targeted for tomorrow. |
Test failing on macos14 citing "ToolTip not found"...Investigation shows that the mouse is not moved when invoked 1st time to desired location on screen causing tooltip to not show...However, subsequent runs of the same test without any change causes it to pass every time.
Workaround is proposed to check if running on 14.x, then invoke a dummy mouse movement to same location which causes the test to pass for several iterations in macos14 environment.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16776/head:pull/16776
$ git checkout pull/16776
Update a local copy of the PR:
$ git checkout pull/16776
$ git pull https://git.openjdk.org/jdk.git pull/16776/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 16776
View PR using the GUI difftool:
$ git pr show -t 16776
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16776.diff
Webrev
Link to Webrev Comment