8320403: C2: PrintIdeal is no longer dumped to tty when xtty is set

[chhagedorn]

During debugging, it was noticed that the output of PrintIdeal is not printed to tty anymore when LogCompilation is enabled (i.e. xtty is set). This was accidentally changed by JDK-8306922. This fix reverts this part of the change to dump to tty instead of xtty which also gets dumped to the log file.

Thanks,
Christian

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8320403: C2: PrintIdeal is no longer dumped to tty when xtty is set (Bug - P4)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16778/head:pull/16778
$ git checkout pull/16778

Update a local copy of the PR:
$ git checkout pull/16778
$ git pull https://git.openjdk.org/jdk.git pull/16778/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16778

View PR using the GUI difftool:
$ git pr show -t 16778

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16778.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back chagedorn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@chhagedorn The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1bb54cb1)

[vnkozlov]

Good and trivial.

[openjdk]

@chhagedorn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320403: C2: PrintIdeal is no longer dumped to tty when xtty is set

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 110 new commits pushed to the master branch:

• 864b39a: 8320564: RISC-V: Minimal build failed after JDK-8316592
• 2bb4b93: 8319569: Several java/util tests should be updated to accept VM flags
• 6016536: 8314745: JFR: @StackFilter
• aac4318: 8320577: Improve MessageHeader's toString() function to make HttpURLConnection's debug log readable
• 572b14a: 8320536: problemlist failing serviceability/attach/ConcAttachTest.java test on macosx
• 30462f9: 8318986: Improve GenericWaitBarrier performance
• 407cdd4: 8320207: doclet incorrectly chooses code font for a See Also link
• 1629a90: 8320331: G1 Full GC Heap verification relies on metadata not reset before verification
• 93bdc2a: 8306055: Add a built-in Catalog to JDK XML module
• a4bd9e4: 8319440: RISC-V: jdk can't be built with clang due to register keyword
• ... and 100 more: https://git.openjdk.org/jdk/compare/fbe19378c38decaff221f6570d1b78bb801a5e5d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TobiHartmann]

Looks good to me.

[chhagedorn]

Thanks Vladimir and Tobias for your reviews!

/integrate

[openjdk]

Going to push as commit c49fb4f.
Since your change was applied there have been 112 commits pushed to the master branch:

• 06d957f: 8320582: Zero: Misplaced CX8 enablement flag
• 14193a0: 8314614: jdk/jshell/ImportTest.java failed with "InternalError: Failed remote listen"
• 864b39a: 8320564: RISC-V: Minimal build failed after JDK-8316592
• 2bb4b93: 8319569: Several java/util tests should be updated to accept VM flags
• 6016536: 8314745: JFR: @StackFilter
• aac4318: 8320577: Improve MessageHeader's toString() function to make HttpURLConnection's debug log readable
• 572b14a: 8320536: problemlist failing serviceability/attach/ConcAttachTest.java test on macosx
• 30462f9: 8318986: Improve GenericWaitBarrier performance
• 407cdd4: 8320207: doclet incorrectly chooses code font for a See Also link
• 1629a90: 8320331: G1 Full GC Heap verification relies on metadata not reset before verification
• ... and 102 more: https://git.openjdk.org/jdk/compare/fbe19378c38decaff221f6570d1b78bb801a5e5d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@chhagedorn Pushed as commit c49fb4f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.