Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320601: ProblemList java/lang/invoke/lambda/LambdaFileEncodingSerialization.java on linux-all #16784

Closed
wants to merge 1 commit into from

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Nov 22, 2023

java/lang/invoke/lambda/LambdaFileEncodingSerialization.java is already problem listed on linux-x64. However, the issue is not processor specific. We see the failure on linux on other architectures as well.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8320601: ProblemList java/lang/invoke/lambda/LambdaFileEncodingSerialization.java on linux-all (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16784/head:pull/16784
$ git checkout pull/16784

Update a local copy of the PR:
$ git checkout pull/16784
$ git pull https://git.openjdk.org/jdk.git pull/16784/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16784

View PR using the GUI difftool:
$ git pr show -t 16784

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16784.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 22, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title JDK-8320601 8320601: ProblemList java/lang/invoke/lambda/LambdaFileEncodingSerialization.java on linux-all Nov 22, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 22, 2023
@openjdk
Copy link

openjdk bot commented Nov 22, 2023

@RealCLanger To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@RealCLanger
Copy link
Contributor Author

/label add core-libs,compiler

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org compiler compiler-dev@openjdk.org labels Nov 22, 2023
@openjdk
Copy link

openjdk bot commented Nov 22, 2023

@RealCLanger
The core-libs label was successfully added.

The compiler label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Nov 22, 2023

Webrevs

@MBaesken
Copy link
Member

In the test java/lang/invoke/lambda/LambdaFileEncodingSerialization.java we set already

env.put("LC_ALL", "en_US.UTF-8"); // Ensure locale supports the test requirements, lambda with a UTF char

env.put("LC_ALL", "en_US.UTF-8"); // Ensure locale supports the test requirements, lambda with a UTF char

is that maybe not sufficient on some systems and some other env var must be set ?

Copy link
Member

@MBaesken MBaesken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to do it on all Linux CPU archs; however I wonder about the following - is there maybe some environment variable setting missing in the test that otherwise would make the test run successfully ?

@openjdk
Copy link

openjdk bot commented Nov 23, 2023

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320601: ProblemList java/lang/invoke/lambda/LambdaFileEncodingSerialization.java on linux-all

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • 8db7bad: 8319813: Remove upper limit on number of compiler phases in phasetype.hpp
  • c49fb4f: 8320403: C2: PrintIdeal is no longer dumped to tty when xtty is set
  • 06d957f: 8320582: Zero: Misplaced CX8 enablement flag
  • 14193a0: 8314614: jdk/jshell/ImportTest.java failed with "InternalError: Failed remote listen"
  • 864b39a: 8320564: RISC-V: Minimal build failed after JDK-8316592
  • 2bb4b93: 8319569: Several java/util tests should be updated to accept VM flags
  • 6016536: 8314745: JFR: @StackFilter
  • aac4318: 8320577: Improve MessageHeader's toString() function to make HttpURLConnection's debug log readable
  • 572b14a: 8320536: problemlist failing serviceability/attach/ConcAttachTest.java test on macosx
  • 30462f9: 8318986: Improve GenericWaitBarrier performance
  • ... and 7 more: https://git.openjdk.org/jdk/compare/25cebe8c3ed5c03b4da2da5bb2f7637c8cd40581...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 23, 2023
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 27, 2023

Going to push as commit f6e5559.
Since your change was applied there have been 35 commits pushed to the master branch:

  • bddcd08: 8304701: Request with timeout aborts later in-flight request on HTTP/1.1 cxn
  • 91279fc: 8319778: Remove unreachable code in ObjectSynchronizer::exit
  • 6aa1976: 8320363: ppc64 TypeEntries::type_unknown logic looks wrong, missed optimization opportunity
  • 4d50df6: 8320691: Timeout handler on Windows takes 2 hours to complete
  • 0c9a61c: 8319220: Pattern matching switch with a lot of cases is unduly slow
  • 26c3390: 8320383: refresh libraries cache on AIX in VMError::report
  • fc31474: 8318913: The module-infos for --release data do not contain pre-set versions
  • df1b896: 8320679: [JVMCI] invalid code in PushLocalFrame event message
  • c75c388: 8318776: Require supports_cx8 to always be true
  • 14557e7: 8314502: Change the comparator taking version of GrowableArray::find to be a template method
  • ... and 25 more: https://git.openjdk.org/jdk/compare/25cebe8c3ed5c03b4da2da5bb2f7637c8cd40581...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 27, 2023
@openjdk openjdk bot closed this Nov 27, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 27, 2023
@openjdk
Copy link

openjdk bot commented Nov 27, 2023

@RealCLanger Pushed as commit f6e5559.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the patch-1 branch February 9, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants