Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320655: awt screencast robot spin and sync issues with native libpipewire api #16794

Closed
wants to merge 3 commits into from

Conversation

antbob
Copy link
Contributor

@antbob antbob commented Nov 23, 2023

This patch addresses the issues described in the https://bugs.openjdk.org/browse/JDK-8320655 by fixing the proper locking and signalling around libpipewire thread loop condition variables and also fixing libpipewire error detection and signalling and propagation to the screencast API. This makes the screencast robot stable enough to consistently make it thru the entire javax/swing jtreg suite without hanging and also significantly reduces CPU consumption as there is no longer any burning spinners since they are now waiting on related conditions proper.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8320655: awt screencast robot spin and sync issues with native libpipewire api (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16794/head:pull/16794
$ git checkout pull/16794

Update a local copy of the PR:
$ git checkout pull/16794
$ git pull https://git.openjdk.org/jdk.git pull/16794/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16794

View PR using the GUI difftool:
$ git pr show -t 16794

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16794.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 23, 2023

👋 Welcome back antbob! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 23, 2023
@openjdk
Copy link

openjdk bot commented Nov 23, 2023

@antbob The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Nov 23, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 23, 2023

Webrevs

@jerboaa
Copy link
Contributor

jerboaa commented Nov 23, 2023

@antbob Please trigger a test run of GHA. You should be able to do that in https://github.com/antbob/jdk/actions/workflows/main.yml (manual trigger). Thanks!

@prrace
Copy link
Contributor

prrace commented Nov 30, 2023

@antbob Please trigger a test run of GHA. You should be able to do that in https://github.com/antbob/jdk/actions/workflows/main.yml (manual trigger). Thanks!

That is pointless for this change. There are ZERO tests that GHA runs that are related to client.

It will test that it builds, but nothing more.

@jerboaa
Copy link
Contributor

jerboaa commented Nov 30, 2023

It will test that it builds, but nothing more.

Right, thanks. Still useful it's not breaking a build :) Besides, the settings carry forward for future PRs.

@openjdk
Copy link

openjdk bot commented Dec 1, 2023

@antbob This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320655: awt screencast robot spin and sync issues with native libpipewire api

Reviewed-by: azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • f32ab8c: 8320924: Improve heap dump performance by optimizing archived object checks
  • 93b9235: 8321120: Shenandoah: Remove ShenandoahElasticTLAB flag
  • 9b8eaa2: 8319872: AArch64: [vectorapi] Implementation of unsigned (zero extended) casts
  • b9b8263: 8317307: test/jdk/com/sun/jndi/ldap/LdapPoolTimeoutTest.java fails with ConnectException: Connection timed out: no further information
  • 0d0a657: 5108458: JTable does not properly layout its content
  • 2b00ac0: 8308753: Class-File API transition to Preview
  • b9df827: 8309871: jdk/jfr/api/consumer/recordingstream/TestSetEndTime.java timed out
  • 9498469: 8318983: Fix comment typo in PKCS12Passwd.java
  • 4dcbd13: 8314905: jdk/jfr/tool/TestView.java fails with RuntimeException 'Invoked Concurrent' missing from stdout/stderr
  • 5dee2a3: 8320440: Implementation of Structured Concurrency (Second Preview)
  • ... and 9 more: https://git.openjdk.org/jdk/compare/3087e14cde9257680f0406b11942f9cb7739cb7b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@azvegint) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 1, 2023
@antbob
Copy link
Contributor Author

antbob commented Dec 4, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 4, 2023
@openjdk
Copy link

openjdk bot commented Dec 4, 2023

@antbob
Your change (at version c764a85) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Dec 4, 2023

32 bit test failure seems unrelated.

@jerboaa
Copy link
Contributor

jerboaa commented Dec 4, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 4, 2023

Going to push as commit c17b8cf.
Since your change was applied there have been 20 commits pushed to the master branch:

  • ed5b8c3: 8225220: When the Tab Policy is checked,the scroll button direction displayed incorrectly.
  • f32ab8c: 8320924: Improve heap dump performance by optimizing archived object checks
  • 93b9235: 8321120: Shenandoah: Remove ShenandoahElasticTLAB flag
  • 9b8eaa2: 8319872: AArch64: [vectorapi] Implementation of unsigned (zero extended) casts
  • b9b8263: 8317307: test/jdk/com/sun/jndi/ldap/LdapPoolTimeoutTest.java fails with ConnectException: Connection timed out: no further information
  • 0d0a657: 5108458: JTable does not properly layout its content
  • 2b00ac0: 8308753: Class-File API transition to Preview
  • b9df827: 8309871: jdk/jfr/api/consumer/recordingstream/TestSetEndTime.java timed out
  • 9498469: 8318983: Fix comment typo in PKCS12Passwd.java
  • 4dcbd13: 8314905: jdk/jfr/tool/TestView.java fails with RuntimeException 'Invoked Concurrent' missing from stdout/stderr
  • ... and 10 more: https://git.openjdk.org/jdk/compare/3087e14cde9257680f0406b11942f9cb7739cb7b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 4, 2023
@openjdk openjdk bot closed this Dec 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 4, 2023
@openjdk
Copy link

openjdk bot commented Dec 4, 2023

@jerboaa @antbob Pushed as commit c17b8cf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@antbob antbob deleted the screencast_robot branch December 4, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
5 participants