8320663: Fix C syntax in LIB_SETUP_HSDIS_BINUTILS

[magicus]

The C snippet in AC_COMPILE_IFELSE is incorrect.

As noted by @galderz: #15138 (comment)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8320663: Fix C syntax in LIB_SETUP_HSDIS_BINUTILS (Bug - P3)

Reviewers

• Robbin Ehn (@robehn - Reviewer)

Contributors

• Galder Zamarreño <galder@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16795/head:pull/16795
$ git checkout pull/16795

Update a local copy of the PR:
$ git checkout pull/16795
$ git pull https://git.openjdk.org/jdk.git pull/16795/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16795

View PR using the GUI difftool:
$ git pr show -t 16795

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16795.diff

Webrev

Link to Webrev Comment

[magicus]

/contributor add @galderz

[bridgekeeper]

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@magicus @galderz was not found in the census.

Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

• /contributor add @openjdk-bot
• /contributor add duke
• /contributor add J. Duke <duke@openjdk.org>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

[openjdk]

@magicus The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (a6783ac9)

[robehn]

Thank you @magicus and @galderz!

Looks good!

[openjdk]

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320663: Fix C syntax in LIB_SETUP_HSDIS_BINUTILS

Co-authored-by: Galder Zamarreño <galder@openjdk.org>
Reviewed-by: rehn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

• 3787ff8: 8319700: [AArch64] C2 compilation fails with "Field too big for insn"
• 99b9cb0: 8320586: update manual test/jdk/TEST.groups
• 8db7bad: 8319813: Remove upper limit on number of compiler phases in phasetype.hpp
• c49fb4f: 8320403: C2: PrintIdeal is no longer dumped to tty when xtty is set
• 06d957f: 8320582: Zero: Misplaced CX8 enablement flag
• 14193a0: 8314614: jdk/jshell/ImportTest.java failed with "InternalError: Failed remote listen"
• 864b39a: 8320564: RISC-V: Minimal build failed after JDK-8316592
• 2bb4b93: 8319569: Several java/util tests should be updated to accept VM flags
• 6016536: 8314745: JFR: @StackFilter
• aac4318: 8320577: Improve MessageHeader's toString() function to make HttpURLConnection's debug log readable
• ... and 27 more: https://git.openjdk.org/jdk/compare/9598ff83860235281a08091128b5df90a4a76916...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[magicus]

/contributor add galderz

[openjdk]

@magicus galderz was not found in the census.

Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

• /contributor add @openjdk-bot
• /contributor add duke
• /contributor add J. Duke <duke@openjdk.org>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

[magicus]

/contributor add galder

[openjdk]

@magicus
Contributor Galder Zamarreño <galder@openjdk.org> successfully added.

[magicus]

/integrate

[openjdk]

Going to push as commit beaa79c.
Since your change was applied there have been 37 commits pushed to the master branch:

• 3787ff8: 8319700: [AArch64] C2 compilation fails with "Field too big for insn"
• 99b9cb0: 8320586: update manual test/jdk/TEST.groups
• 8db7bad: 8319813: Remove upper limit on number of compiler phases in phasetype.hpp
• c49fb4f: 8320403: C2: PrintIdeal is no longer dumped to tty when xtty is set
• 06d957f: 8320582: Zero: Misplaced CX8 enablement flag
• 14193a0: 8314614: jdk/jshell/ImportTest.java failed with "InternalError: Failed remote listen"
• 864b39a: 8320564: RISC-V: Minimal build failed after JDK-8316592
• 2bb4b93: 8319569: Several java/util tests should be updated to accept VM flags
• 6016536: 8314745: JFR: @StackFilter
• aac4318: 8320577: Improve MessageHeader's toString() function to make HttpURLConnection's debug log readable
• ... and 27 more: https://git.openjdk.org/jdk/compare/9598ff83860235281a08091128b5df90a4a76916...master

Your commit was automatically rebased without conflicts.

[openjdk]

@magicus Pushed as commit beaa79c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.