8294549: configure script should detect unsupported path

[magicus]

The OpenJDK build system does not support building when the source code resides on a path that contains a space. This requirement is documented in the build instructions but not enforced by the configure script.

This change adds an explicit checks to the wrapper configure script that fail the build if the source code to be built is located in a directory who's path contains a space character or the build path cannot be determined.

This is a revival of the old patch in #10477, created in collaboration between by @bondolo and myself.

/contributor add mduigou

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8294549: configure script should detect unsupported path (Enhancement - P4)

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)

Contributors

• Mike Duigou <mduigou@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16798/head:pull/16798
$ git checkout pull/16798

Update a local copy of the PR:
$ git checkout pull/16798
$ git pull https://git.openjdk.org/jdk.git pull/16798/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16798

View PR using the GUI difftool:
$ git pr show -t 16798

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16798.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@magicus
Contributor Mike Duigou <mduigou@openjdk.org> successfully added.

[openjdk]

@magicus The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (bc608c56)

[bondolo]

LGTM. As a contributor (though not much of my original contribution made it in to the final patch) I don't believe I can act as a reviewer.

Thank you for bringing this change across the line!

[openjdk]

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294549: configure script should detect unsupported path

Co-authored-by: Mike Duigou <mduigou@openjdk.org>
Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 58 new commits pushed to the master branch:

• 4977922: 8320330: Improve implementation of RShift Value
• a40d8d9: 8314220: Configurable InlineCacheBuffer size
• 1272368: 8318113: CSS.BackgroundImage doesn't implement equals
• 28d3762: 8320618: NPE: Cannot invoke "java.lang.constant.ClassDesc.isArray()" because "this.sym" is null
• f6e5559: 8320601: ProblemList java/lang/invoke/lambda/LambdaFileEncodingSerialization.java on linux-all
• bddcd08: 8304701: Request with timeout aborts later in-flight request on HTTP/1.1 cxn
• 91279fc: 8319778: Remove unreachable code in ObjectSynchronizer::exit
• 6aa1976: 8320363: ppc64 TypeEntries::type_unknown logic looks wrong, missed optimization opportunity
• 4d50df6: 8320691: Timeout handler on Windows takes 2 hours to complete
• 0c9a61c: 8319220: Pattern matching switch with a lot of cases is unduly slow
• ... and 48 more: https://git.openjdk.org/jdk/compare/9598ff83860235281a08091128b5df90a4a76916...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[magicus]

/integrate

[openjdk]

Going to push as commit a006d7e.
Since your change was applied there have been 58 commits pushed to the master branch:

• 4977922: 8320330: Improve implementation of RShift Value
• a40d8d9: 8314220: Configurable InlineCacheBuffer size
• 1272368: 8318113: CSS.BackgroundImage doesn't implement equals
• 28d3762: 8320618: NPE: Cannot invoke "java.lang.constant.ClassDesc.isArray()" because "this.sym" is null
• f6e5559: 8320601: ProblemList java/lang/invoke/lambda/LambdaFileEncodingSerialization.java on linux-all
• bddcd08: 8304701: Request with timeout aborts later in-flight request on HTTP/1.1 cxn
• 91279fc: 8319778: Remove unreachable code in ObjectSynchronizer::exit
• 6aa1976: 8320363: ppc64 TypeEntries::type_unknown logic looks wrong, missed optimization opportunity
• 4d50df6: 8320691: Timeout handler on Windows takes 2 hours to complete
• 0c9a61c: 8319220: Pattern matching switch with a lot of cases is unduly slow
• ... and 48 more: https://git.openjdk.org/jdk/compare/9598ff83860235281a08091128b5df90a4a76916...master

Your commit was automatically rebased without conflicts.

[openjdk]

@magicus Pushed as commit a006d7e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.