Skip to content

Conversation

@dougxc
Copy link
Member

@dougxc dougxc commented Nov 23, 2023

This is a trivial fix to the JVMCI event logged when PushLocalFrame fails in a new libjvmci env. It must report the value of result, not _init_error.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8320679: [JVMCI] invalid code in PushLocalFrame event message (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16803/head:pull/16803
$ git checkout pull/16803

Update a local copy of the PR:
$ git checkout pull/16803
$ git pull https://git.openjdk.org/jdk.git pull/16803/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16803

View PR using the GUI difftool:
$ git pr show -t 16803

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16803.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 23, 2023

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 23, 2023

@dougxc The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels Nov 23, 2023
@dougxc dougxc changed the title 320679: [JVMCI] invalid code in PushLocalFrame event message 8320679: [JVMCI] invalid code in PushLocalFrame event message Nov 23, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 23, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 23, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 23, 2023

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320679: [JVMCI] invalid code in PushLocalFrame event message

Reviewed-by: never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 23, 2023
@dougxc
Copy link
Member Author

dougxc commented Nov 23, 2023

Thanks for the review. I'm integrating this based on a single review given how trivial the change is.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 23, 2023

Going to push as commit df1b896.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 23, 2023
@openjdk openjdk bot closed this Nov 23, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 23, 2023
@openjdk
Copy link

openjdk bot commented Nov 23, 2023

@dougxc Pushed as commit df1b896.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants