Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320781: Fix whitespace in j.l.Double and j.u.z.ZipInputStream @snippets #16827

Closed
wants to merge 1 commit into from

Conversation

eirbjo
Copy link
Contributor

@eirbjo eirbjo commented Nov 27, 2023

Please review this trivial, formatting and documentation-only change which adds missing whitespace around a few if statements, while statements and assigments in @snippet code in j.l.Double and j.u.z.ZipInputStream.

While there are many similar issues in the OpenJDK code base, these were the only instances found in @snippet code in the API of java.base, so it could be worthwhile fixing.

While updating the snippet in ZipInputStream, I took the liberty to also add lang = "java" since this seems more commonly included around the code base.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8320781: Fix whitespace in j.l.Double and j.u.z.ZipInputStream @snippets (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16827/head:pull/16827
$ git checkout pull/16827

Update a local copy of the PR:
$ git checkout pull/16827
$ git pull https://git.openjdk.org/jdk.git pull/16827/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16827

View PR using the GUI difftool:
$ git pr show -t 16827

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16827.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 27, 2023

👋 Welcome back eirbjo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 27, 2023
@openjdk
Copy link

openjdk bot commented Nov 27, 2023

@eirbjo The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 27, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 27, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 27, 2023

@eirbjo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320781: Fix whitespace in j.l.Double and j.u.z.ZipInputStream @snippets

Reviewed-by: lancea, bpb, darcy, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • 464dc3d: 8319633: runtime/posixSig/TestPosixSig.java intermittent timeouts on UNIX
  • efc3922: 8319048: Monitor deflation unlink phase prolongs time to safepoint
  • debf0ec: 8313355: javax/management/remote/mandatory/notif/ListenerScaleTest.java failed with "Exception: Failed: ratio=792.2791601423487"
  • 20aae3c: 8320533: Adjust capstone integration for v6 changes
  • 0678253: 8320602: Lock contention in SchemaDVFactory.getInstance()
  • f1a24f6: 8318599: HttpURLConnection cache issues leading to crashes in JGSS w/ native GSS introduced by 8303809
  • 7848ed7: 8301856: Generated .spec file for RPM installers uninstalls desktop launcher on update
  • 726f854: 8320706: RuntimePackageTest.testUsrInstallDir test fails on Linux
  • 1bb250c: 8261837: SIGSEGV in ciVirtualCallTypeData::translate_from
  • 5f7f2c4: 8320249: tools/jpackage/share/AddLauncherTest.java#id1 fails intermittently on Windows in verifyDescription
  • ... and 8 more: https://git.openjdk.org/jdk/compare/a40d8d97e84d88d1a65aba81bfc09339be95e427...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@LanceAndersen, @bplb, @jddarcy, @jaikiran) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 27, 2023
@eirbjo
Copy link
Contributor Author

eirbjo commented Nov 27, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 27, 2023
@openjdk
Copy link

openjdk bot commented Nov 27, 2023

@eirbjo
Your change (at version 2401d79) is now ready to be sponsored by a Committer.

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please add a "noreg-doc" label to the JDK-8320781 issue.

@eirbjo
Copy link
Contributor Author

eirbjo commented Nov 28, 2023

Looks good to me. Please add a "noreg-doc" label to the JDK-8320781 issue.

Thanks, label added! I'll need a sponsor for the integration of this change.

@jaikiran
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 28, 2023

Going to push as commit 99f870c.
Since your change was applied there have been 19 commits pushed to the master branch:

  • a5ccd3b: 8267532: C2: Profile and prune untaken exception handlers
  • 464dc3d: 8319633: runtime/posixSig/TestPosixSig.java intermittent timeouts on UNIX
  • efc3922: 8319048: Monitor deflation unlink phase prolongs time to safepoint
  • debf0ec: 8313355: javax/management/remote/mandatory/notif/ListenerScaleTest.java failed with "Exception: Failed: ratio=792.2791601423487"
  • 20aae3c: 8320533: Adjust capstone integration for v6 changes
  • 0678253: 8320602: Lock contention in SchemaDVFactory.getInstance()
  • f1a24f6: 8318599: HttpURLConnection cache issues leading to crashes in JGSS w/ native GSS introduced by 8303809
  • 7848ed7: 8301856: Generated .spec file for RPM installers uninstalls desktop launcher on update
  • 726f854: 8320706: RuntimePackageTest.testUsrInstallDir test fails on Linux
  • 1bb250c: 8261837: SIGSEGV in ciVirtualCallTypeData::translate_from
  • ... and 9 more: https://git.openjdk.org/jdk/compare/a40d8d97e84d88d1a65aba81bfc09339be95e427...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 28, 2023
@openjdk openjdk bot closed this Nov 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 28, 2023
@openjdk
Copy link

openjdk bot commented Nov 28, 2023

@jaikiran @eirbjo Pushed as commit 99f870c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
5 participants