-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8320781: Fix whitespace in j.l.Double and j.u.z.ZipInputStream @snippets #16827
Conversation
👋 Welcome back eirbjo! A progress list of the required criteria for merging this PR into |
@eirbjo This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 18 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@LanceAndersen, @bplb, @jddarcy, @jaikiran) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Please add a "noreg-doc" label to the JDK-8320781 issue.
Thanks, label added! I'll need a sponsor for the integration of this change. |
/sponsor |
Going to push as commit 99f870c.
Your commit was automatically rebased without conflicts. |
Please review this trivial, formatting and documentation-only change which adds missing whitespace around a few
if
statements,while
statements and assigments in@snippet
code inj.l.Double
andj.u.z.ZipInputStream
.While there are many similar issues in the OpenJDK code base, these were the only instances found in
@snippet
code in the API ofjava.base
, so it could be worthwhile fixing.While updating the snippet in
ZipInputStream
, I took the liberty to also addlang = "java"
since this seems more commonly included around the code base.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16827/head:pull/16827
$ git checkout pull/16827
Update a local copy of the PR:
$ git checkout pull/16827
$ git pull https://git.openjdk.org/jdk.git pull/16827/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 16827
View PR using the GUI difftool:
$ git pr show -t 16827
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16827.diff
Webrev
Link to Webrev Comment