Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8257847: Tiered should publish MDO data pointer for interpreter after profile start #1683

Closed
wants to merge 2 commits into from
Closed

8257847: Tiered should publish MDO data pointer for interpreter after profile start #1683

wants to merge 2 commits into from

Conversation

veresov
Copy link
Contributor

@veresov veresov commented Dec 8, 2020 •
edited by openjdk bot

Tiered policy may decide to start profiling in interpreter if C1 is overloaded with requests. It should publish an appropriate data pointer for the current bci in order for the interpreter to start profiling immediately and not wait for the second invocation.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257847: Tiered should publish MDO data pointer for interpreter after profile start

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1683/head:pull/1683
$ git checkout pull/1683

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 8, 2020

👋 Welcome back iveresov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 8, 2020
@openjdk
Copy link

openjdk bot commented Dec 8, 2020

@veresov The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Dec 8, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 8, 2020 •
edited

Webrevs

@veresov veresov changed the title 8257847: Tiered should publish MDO data pointer for interpreter after profile start. 8257847: Tiered should publish MDO data pointer for interpreter after profile start Dec 8, 2020
TobiHartmann
TobiHartmann approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@openjdk
Copy link

openjdk bot commented Dec 8, 2020 •
edited

@veresov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257847: Tiered should publish MDO data pointer for interpreter after profile start

Reviewed-by: thartmann, kvn, dlong

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • b29f9cd: 8075778: Add javadoc tag to avoid duplication of return information in simple situations.
  • 48d8650: 8257845: Integrate JEP 390
  • ed4c4ee: 8256299: Implement JEP 396: Strongly Encapsulate JDK Internals by Default
  • c47ab5f: 8256515: javax.xml.XMLEventReader produces incorrect START_DOCUMENT event
  • 291ba97: 8251267: CDS tests should use CDSTestUtils.getOutputDir instead of System.getProperty("user.dir")
  • f48d5d1: 8257789: Fix incremental build of test-image and bundles
  • 1a9ed92: 8200102: NativeLibraryTest.java fails intermittently, unloaded count is not same as expected
  • 264feb3: 8257905: Make fixpath.sh more liberal in accepting paths embedded in arguments
  • 044616b: 8252049: Native memory leak in ciMethodData ctor
  • fab6158: 8236413: AbstractConnectTimeout should tolerate both NoRouteToHostException and UnresolvedAddressException
  • ... and 6 more: https://git.openjdk.java.net/jdk/compare/1d0adbb812bc4b40fb614f245dd8ed2ef66ff073...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 8, 2020
dean-long
dean-long reviewed Dec 8, 2020
View reviewed changes
src/hotspot/share/compiler/tieredThresholdPolicy.cpp
MethodData* mdo = mh->method_data();
if (mdo != NULL) {
JavaThread* jt = THREAD->as_Java_thread();
frame last_frame = jt->last_frame();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some interpreter code is using LastFrameAccessor instead. Does it matter here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it doesn't. It's just a utility class that's used in interpreterRuntime.cpp.

@veresov
Copy link
Contributor Author

veresov commented Dec 9, 2020

/integrate

@openjdk openjdk bot closed this Dec 9, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 9, 2020
@openjdk
Copy link

openjdk bot commented Dec 9, 2020

@veresov Since your change was applied there have been 17 commits pushed to the master branch:

  • 2a62d5d: 8256917: Use combo @returns tag in java.compiler javadoc
  • b29f9cd: 8075778: Add javadoc tag to avoid duplication of return information in simple situations.
  • 48d8650: 8257845: Integrate JEP 390
  • ed4c4ee: 8256299: Implement JEP 396: Strongly Encapsulate JDK Internals by Default
  • c47ab5f: 8256515: javax.xml.XMLEventReader produces incorrect START_DOCUMENT event
  • 291ba97: 8251267: CDS tests should use CDSTestUtils.getOutputDir instead of System.getProperty("user.dir")
  • f48d5d1: 8257789: Fix incremental build of test-image and bundles
  • 1a9ed92: 8200102: NativeLibraryTest.java fails intermittently, unloaded count is not same as expected
  • 264feb3: 8257905: Make fixpath.sh more liberal in accepting paths embedded in arguments
  • 044616b: 8252049: Native memory leak in ciMethodData ctor
  • ... and 7 more: https://git.openjdk.java.net/jdk/compare/1d0adbb812bc4b40fb614f245dd8ed2ef66ff073...master

Your commit was automatically rebased without conflicts.

Pushed as commit 10da767.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vnkozlov vnkozlov vnkozlov approved these changes

@TobiHartmann TobiHartmann TobiHartmann approved these changes

@dean-long dean-long dean-long approved these changes

Assignees
No one assigned
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
4 participants
@veresov @vnkozlov @TobiHartmann @dean-long