New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8257847: Tiered should publish MDO data pointer for interpreter after profile start #1683
Conversation
👋 Welcome back iveresov! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me.
@veresov This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 16 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
MethodData* mdo = mh->method_data(); | ||
if (mdo != NULL) { | ||
JavaThread* jt = THREAD->as_Java_thread(); | ||
frame last_frame = jt->last_frame(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some interpreter code is using LastFrameAccessor instead. Does it matter here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it doesn't. It's just a utility class that's used in interpreterRuntime.cpp.
/integrate |
@veresov Since your change was applied there have been 17 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 10da767. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Tiered policy may decide to start profiling in interpreter if C1 is overloaded with requests. It should publish an appropriate data pointer for the current bci in order for the interpreter to start profiling immediately and not wait for the second invocation.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1683/head:pull/1683
$ git checkout pull/1683