Skip to content

Conversation

@jddarcy
Copy link
Member

@jddarcy jddarcy commented Nov 27, 2023

Straightforward test update for a new language feature.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8320806: Augment test/langtools/tools/javac/versions/Versions.java for JDK 22 language changes (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16833/head:pull/16833
$ git checkout pull/16833

Update a local copy of the PR:
$ git checkout pull/16833
$ git pull https://git.openjdk.org/jdk.git pull/16833/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16833

View PR using the GUI difftool:
$ git pr show -t 16833

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16833.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 27, 2023

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 27, 2023
@openjdk
Copy link

openjdk bot commented Nov 27, 2023

@jddarcy The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Nov 27, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 27, 2023

Webrevs

Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk
Copy link

openjdk bot commented Nov 29, 2023

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320806: Augment test/langtools/tools/javac/versions/Versions.java for JDK 22 language changes

Reviewed-by: jlahoda, vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 44 new commits pushed to the master branch:

  • a2c5f1f: 8319417: (dc) DatagramChannel.connect undocumented behavior
  • abf2e49: 8320859: gtest high malloc footprint caused by BufferNodeAllocator stress test
  • 033cced: 8320368: Per-CPU optimization of Klass range reservation
  • 48960df: 8316734: URLEncoder should specify that replacement bytes will be used in case of coding error
  • 1594653: 8310644: Make panama memory segment close use async handshakes
  • 65dfcae: 8308399: Recommend --release when -source and -target are misused
  • 335f5db: 8320911: RISC-V: Enable hotspot/jtreg/compiler/intrinsics/chacha/TestChaCha20.java
  • 77d604a: 8319373: Serial: Refactor dirty cards scanning during Young GC
  • 38cfb22: 8318706: Implement JEP 423: Region Pinning for G1
  • e44d4b2: 8320858: Move jpackage tests to tier3
  • ... and 34 more: https://git.openjdk.org/jdk/compare/82967f45db3b9555be03fcabdba380852ea21e2c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 29, 2023
Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jddarcy
Copy link
Member Author

jddarcy commented Nov 29, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Nov 29, 2023

Going to push as commit b68356b.
Since your change was applied there have been 47 commits pushed to the master branch:

  • d783aa3: 8320940: Fix typo in java.lang.Double
  • 43c7f6a: 8320907: Shenandoah: Remove ShenandoahSelfFixing flag
  • da7bcfc: 8319935: Ensure only one JvmtiThreadState is created for one JavaThread associated with attached native thread
  • a2c5f1f: 8319417: (dc) DatagramChannel.connect undocumented behavior
  • abf2e49: 8320859: gtest high malloc footprint caused by BufferNodeAllocator stress test
  • 033cced: 8320368: Per-CPU optimization of Klass range reservation
  • 48960df: 8316734: URLEncoder should specify that replacement bytes will be used in case of coding error
  • 1594653: 8310644: Make panama memory segment close use async handshakes
  • 65dfcae: 8308399: Recommend --release when -source and -target are misused
  • 335f5db: 8320911: RISC-V: Enable hotspot/jtreg/compiler/intrinsics/chacha/TestChaCha20.java
  • ... and 37 more: https://git.openjdk.org/jdk/compare/82967f45db3b9555be03fcabdba380852ea21e2c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 29, 2023
@openjdk openjdk bot closed this Nov 29, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 29, 2023
@openjdk
Copy link

openjdk bot commented Nov 29, 2023

@jddarcy Pushed as commit b68356b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jddarcy jddarcy deleted the JDK-8320806 branch October 27, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiler compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants