8320863: dsymutil command leaves around temporary directories

[jaikiran]

Can I please get a review of this change which proposes to workaround a bug in dsymutil tool on macos?

As noted in https://bugs.openjdk.org/browse/JDK-8320863, the dsymutil tool shipped in Xcode 14.3.1 has a bug which causes it to create a temporary directories and leave them around, whenever that tool is used. JDK build uses that tool in the build process to generate debuginfo files on macos. When I run the JDK mainline build locally on my macos system, I see that every make clean images build ends up creating and leaving 72 new dsymutil-* temporary directories.

The bug in dsymutil has been acknowledged and fixed in llvm upstream project llvm/llvm-project#61920. Until that fix makes it into Xcode released versions, the JDK build would need a workaround. The commit in this PR proposes to pass --reproducer Off option to this command. Doing so prevents the tool from leaving around these temporary directories. As noted in the linked llvm project's issue, these temporary directories are used for generating any crash report reproducers so that they can then be submitted as bug reports. Using --reproducer Off disables the reproducer generation llvm/llvm-project#61920 (comment):

The default is that if dsymutil crashes it will produce a reproducer for filing a bug report. So with this option you will not get that.

Not generating these reproducers should be OK for the JDK builds.

Before doing this change, I ran several make clean images build locally on my macos and verified that every single run generates these dsymutil temporary directories. After this proposed change, I reran the same command again several times and I have verified that these directories are no longer created.

tier1,tier2, tier3 testing too has completed successfully with this change.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8320863: dsymutil command leaves around temporary directories (Bug - P4)

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)
• Magnus Ihse Bursie (@magicus - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16843/head:pull/16843
$ git checkout pull/16843

Update a local copy of the PR:
$ git checkout pull/16843
$ git pull https://git.openjdk.org/jdk.git pull/16843/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16843

View PR using the GUI difftool:
$ git pr show -t 16843

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16843.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jaikiran The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (91f95fec)

[openjdk]

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320863: dsymutil command leaves around temporary directories

Reviewed-by: erikj, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• db7fedf: 8320358: GHA: ignore jdk* branches
• e33b6c1: 8319437: NMT should show library names in call stacks
• 2fae07f: 8319311: JShell Process Builder should be configurable
• 63ad868: 8319668: Fixup of jar filename typo in BadFactoryTest.sh
• 4bcda60: 8319713: Parallel: Remove PSAdaptiveSizePolicy::should_full_GC
• 99f870c: 8320781: Fix whitespace in j.l.Double and j.u.z.ZipInputStream @snippets
• a5ccd3b: 8267532: C2: Profile and prune untaken exception handlers
• 464dc3d: 8319633: runtime/posixSig/TestPosixSig.java intermittent timeouts on UNIX
• efc3922: 8319048: Monitor deflation unlink phase prolongs time to safepoint
• debf0ec: 8313355: javax/management/remote/mandatory/notif/ListenerScaleTest.java failed with "Exception: Failed: ratio=792.2791601423487"
• ... and 2 more: https://git.openjdk.org/jdk/compare/f1a24f6d4827f9b8648dd2afe6d606dab67d51fe...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[magicus]

Looks good to me.

[magicus]

You can find and erase these folders using find /var/folders -name "dsymutil-*" -type d -delete.

[jaikiran]

Thank you Erik and Magnus for the reviews.

[jaikiran]

/integrate

[openjdk]

Going to push as commit 86bb804.
Since your change was applied there have been 12 commits pushed to the master branch:

• db7fedf: 8320358: GHA: ignore jdk* branches
• e33b6c1: 8319437: NMT should show library names in call stacks
• 2fae07f: 8319311: JShell Process Builder should be configurable
• 63ad868: 8319668: Fixup of jar filename typo in BadFactoryTest.sh
• 4bcda60: 8319713: Parallel: Remove PSAdaptiveSizePolicy::should_full_GC
• 99f870c: 8320781: Fix whitespace in j.l.Double and j.u.z.ZipInputStream @snippets
• a5ccd3b: 8267532: C2: Profile and prune untaken exception handlers
• 464dc3d: 8319633: runtime/posixSig/TestPosixSig.java intermittent timeouts on UNIX
• efc3922: 8319048: Monitor deflation unlink phase prolongs time to safepoint
• debf0ec: 8313355: javax/management/remote/mandatory/notif/ListenerScaleTest.java failed with "Exception: Failed: ratio=792.2791601423487"
• ... and 2 more: https://git.openjdk.org/jdk/compare/f1a24f6d4827f9b8648dd2afe6d606dab67d51fe...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran Pushed as commit 86bb804.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.