8317721: RISC-V: Implement CRC32 intrinsic #16850
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all! Please review this port of
_updateBytesCRC32
intrinsic from AArch64 (for now, plain version).Correctness checks
Tests
test/hotspot/jtreg/compiler/codegen/CRCTest.java
andtest/hotspot/jtreg/compiler/intrinsics/zip/TestCRC32.java
are passed, in both of the_updateBytesCRC32
was used.Performance results on T-Head board
Intrinsic disabled
(
-XX:-UseCRC32Intrinsics
flag)Intrinsic enabled
(
-XX:+UseCRC32Intrinsics
flag)Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16850/head:pull/16850
$ git checkout pull/16850
Update a local copy of the PR:
$ git checkout pull/16850
$ git pull https://git.openjdk.org/jdk.git pull/16850/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 16850
View PR using the GUI difftool:
$ git pr show -t 16850
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16850.diff
Webrev
Link to Webrev Comment