8320899: Select the correct Makefile when running make in build directory

[magicus]

To facilitate running make in the build configuration directory, we create a Makefile out of a template. Unfortunately, this references the real Makefile at $TOPDIR instead of $WORKSPACE_ROOT. They are normally equivalent, but if you are using custom additions, they might not be.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8320899: Select the correct Makefile when running make in build directory (Bug - P4) ⚠️ Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit. See Backports.

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16852/head:pull/16852
$ git checkout pull/16852

Update a local copy of the PR:
$ git checkout pull/16852
$ git pull https://git.openjdk.org/jdk.git pull/16852/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16852

View PR using the GUI difftool:
$ git pr show -t 16852

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16852.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@magicus The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (304d0fa1)

[openjdk]

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320899: Select the correct Makefile when running make in build directory

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• ebbef62: 8320769: Remove ill-adviced "make install" target
• 86bb804: 8320863: dsymutil command leaves around temporary directories

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[magicus]

/integrate

[openjdk]

Going to push as commit 66ae6d5.
Since your change was applied there have been 2 commits pushed to the master branch:

• ebbef62: 8320769: Remove ill-adviced "make install" target
• 86bb804: 8320863: dsymutil command leaves around temporary directories

Your commit was automatically rebased without conflicts.

[openjdk]

@magicus Pushed as commit 66ae6d5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.