8320907: Shenandoah: Remove ShenandoahSelfFixing flag

[shipilev]

We added ShenandoahSelfFixing flag during LRB work to exercise LRB mid-paths better during stress tests. Today, we do not need the flag. Actually, if we ever call LRB for the side-effect of updating the location (e.g. somewhere in roots), then disabling this flag would introduce more bugs. Therefore, we need to remove the flag and make self-fixing unconditional.

Additional testing:

• MacOS AArch64 server fastdebug, hotspot_gc_shenandoah

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8320907: Shenandoah: Remove ShenandoahSelfFixing flag (Enhancement - P4)

Reviewers

• William Kemper (@earthling-amzn - Author)
• Zhengyu Gu (@zhengyu123 - Reviewer)
• Kelvin Nilsen (@kdnilsen - no project role)
• Roman Kennke (@rkennke - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16855/head:pull/16855
$ git checkout pull/16855

Update a local copy of the PR:
$ git checkout pull/16855
$ git pull https://git.openjdk.org/jdk.git pull/16855/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16855

View PR using the GUI difftool:
$ git pr show -t 16855

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16855.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c46f615e)

[zhengyu123]

LGTM

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320907: Shenandoah: Remove ShenandoahSelfFixing flag

Reviewed-by: wkemper, zgu, kdnilsen, rkennke

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

• da7bcfc: 8319935: Ensure only one JvmtiThreadState is created for one JavaThread associated with attached native thread
• a2c5f1f: 8319417: (dc) DatagramChannel.connect undocumented behavior
• abf2e49: 8320859: gtest high malloc footprint caused by BufferNodeAllocator stress test
• 033cced: 8320368: Per-CPU optimization of Klass range reservation
• 48960df: 8316734: URLEncoder should specify that replacement bytes will be used in case of coding error
• 1594653: 8310644: Make panama memory segment close use async handshakes
• 65dfcae: 8308399: Recommend --release when -source and -target are misused
• 335f5db: 8320911: RISC-V: Enable hotspot/jtreg/compiler/intrinsics/chacha/TestChaCha20.java
• 77d604a: 8319373: Serial: Refactor dirty cards scanning during Young GC
• 38cfb22: 8318706: Implement JEP 423: Region Pinning for G1
• ... and 21 more: https://git.openjdk.org/jdk/compare/4bcda602668835c35e2ac6ff6702d15cd249bc2a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[rkennke]

Looks good, thank you!

[shipilev]

Thank you all!

/integrate

[openjdk]

Going to push as commit 43c7f6a.
Since your change was applied there have been 31 commits pushed to the master branch:

• da7bcfc: 8319935: Ensure only one JvmtiThreadState is created for one JavaThread associated with attached native thread
• a2c5f1f: 8319417: (dc) DatagramChannel.connect undocumented behavior
• abf2e49: 8320859: gtest high malloc footprint caused by BufferNodeAllocator stress test
• 033cced: 8320368: Per-CPU optimization of Klass range reservation
• 48960df: 8316734: URLEncoder should specify that replacement bytes will be used in case of coding error
• 1594653: 8310644: Make panama memory segment close use async handshakes
• 65dfcae: 8308399: Recommend --release when -source and -target are misused
• 335f5db: 8320911: RISC-V: Enable hotspot/jtreg/compiler/intrinsics/chacha/TestChaCha20.java
• 77d604a: 8319373: Serial: Refactor dirty cards scanning during Young GC
• 38cfb22: 8318706: Implement JEP 423: Region Pinning for G1
• ... and 21 more: https://git.openjdk.org/jdk/compare/4bcda602668835c35e2ac6ff6702d15cd249bc2a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 43c7f6a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.