8257884: Re-enable sun/security/ssl/SSLSocketImpl/SSLSocketLeak.java as automatic test

[RealCLanger]

The test sun/security/ssl/SSLSocketImpl/SSLSocketLeak.java caused sporadic noise because sometimes it opens more file handles than expected. It was moved to a manual test to quiesce this (JDK-8257670)

It would be good, however, to have this test as an automatic test to be able to spot potential regressions. The threshold for windows should be adapted.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8257884: Re-enable sun/security/ssl/SSLSocketImpl/SSLSocketLeak.java as automatic test

Reviewers

• Xue-Lei Andrew Fan (@XueleiFan - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1686/head:pull/1686
$ git checkout pull/1686

[bridgekeeper]

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@RealCLanger The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (ec6bde7)

[openjdk]

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257884: Re-enable sun/security/ssl/SSLSocketImpl/SSLSocketLeak.java as automatic test

Reviewed-by: xuelei

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• 936a7ac: 8252797: Non-PCH build fails on Ubuntu 16.4 when building with gtests
• d0c5265: 8256149: Weird AST structure for incomplete member select
• a708024: 8257194: Add 'foreign linker API' in 'jdk.incubator.foreign' module desc/summary
• 35e8153: 8257848: -XX:CompileCommand=blackhole,* should be diagnostic
• d2b6619: 8242258: (jrtfs) Path::toUri throws AssertionError for malformed input
• 52ab721: 8254733: HotSpot Style Guide should permit using range-based for loops
• 1d0adbb: 8253644: C2: assert(skeleton_predicate_has_opaque(iff)) failed: unexpected
• 51ac376: 8256411: Based anonymous classes have a weird end position
• 0b6b6eb: 8257813: [redo] C2: Filter type in PhiNode::Value() for induction variables of trip-counted integer loops

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RealCLanger]

/integrate

[openjdk]

@RealCLanger Since your change was applied there have been 23 commits pushed to the master branch:

• 79f1dfb: 8255987: JDI tests fail with com.sun.jdi.ObjectCollectedException
• 9ce3d80: 8257887: java/foreign/TestSegments.java test fails on 32-bit after JDK-8257186
• 10da767: 8257847: Tiered should publish MDO data pointer for interpreter after profile start
• 2a62d5d: 8256917: Use combo @returns tag in java.compiler javadoc
• b29f9cd: 8075778: Add javadoc tag to avoid duplication of return information in simple situations.
• 48d8650: 8257845: Integrate JEP 390
• ed4c4ee: 8256299: Implement JEP 396: Strongly Encapsulate JDK Internals by Default
• c47ab5f: 8256515: javax.xml.XMLEventReader produces incorrect START_DOCUMENT event
• 291ba97: 8251267: CDS tests should use CDSTestUtils.getOutputDir instead of System.getProperty("user.dir")
• f48d5d1: 8257789: Fix incremental build of test-image and bundles
• ... and 13 more: https://git.openjdk.java.net/jdk/compare/500ab45770d9544401edf133aaf7cf7236a69cd8...master

Your commit was automatically rebased without conflicts.

Pushed as commit fae7961.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.