Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320921: GHA: Parallelize hotspot_compiler test jobs #16860

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Nov 28, 2023

In current GHA, hotspot_compiler testing takes a long time, and often takes the longest. On MacOS and Windows it routinely takes 60..80 minutes, while other test groups run in 30..40 minutes. This often drags the total wall clock time to run the GHA up. Fortunately, there are already several parts in hotspot_compiler test group, which we might just run separately:

tier1_compiler = \
:tier1_compiler_1 \
:tier1_compiler_2 \
:tier1_compiler_3 \
:tier1_compiler_not_xcomp

There is a bit of awkwardness about not_xcomp subgroup, which does not have lots of tests. Instead of doing another short job, I think we can just meld it into the quickest "part 2".

# Before
linux-x64 / test (hs/tier1 compiler) 38m 27s 	
windows-x64 / test (hs/tier1 compiler): 1h 17m 30s 	
macos-x64 / test (hs/tier1 compiler): 1h 2m 53s 

# After
linux-x64 / test (hs/tier1 compiler part 1): 11m 38s 	
linux-x64 / test (hs/tier1 compiler part 2): 9m 34s 	
linux-x64 / test (hs/tier1 compiler part 3): 21m 40s 	

windows-x64 / test (hs/tier1 compiler part 1): 24m 19s 	
windows-x64 / test (hs/tier1 compiler part 2): 18m 54s 	
windows-x64 / test (hs/tier1 compiler part 3): 43m 32s 	

macos-x64 / test (hs/tier1 compiler part 1): 26m 44s 	
macos-x64 / test (hs/tier1 compiler part 2): 20m 40s	
macos-x64 / test (hs/tier1 compiler part 3): 42m 10s

Additional testing:

  • GHA (current run is in progress, but I had clean runs before)

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8320921: GHA: Parallelize hotspot_compiler test jobs (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16860/head:pull/16860
$ git checkout pull/16860

Update a local copy of the PR:
$ git checkout pull/16860
$ git pull https://git.openjdk.org/jdk.git pull/16860/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16860

View PR using the GUI difftool:
$ git pr show -t 16860

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16860.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 28, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 28, 2023

@shipilev The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Nov 28, 2023
@shipilev shipilev marked this pull request as ready for review November 29, 2023 09:29
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 29, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 29, 2023

Webrevs

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@openjdk
Copy link

openjdk bot commented Nov 29, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320921: GHA: Parallelize hotspot_compiler test jobs

Reviewed-by: stuefe, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 47 new commits pushed to the master branch:

  • 0d14636: 8320515: assert(monitor->object_peek() != nullptr) failed: Owned monitors should not have a dead object
  • d6b4aa0: 8318157: RISC-V: implement ensureMaterializedForStackWalk intrinsic
  • 7766785: 8319372: C2 compilation fails with "Bad immediate dominator info"
  • 940f67c: 8318854: [macos14] Running any AWT app prints Secure coding warning
  • c864317: 8320888: Shenandoah: Enable ShenandoahVerifyOptoBarriers in debug builds
  • d1e73b1: 8318626: GetClassFields does not filter out ConstantPool.constantPoolOop field
  • ea6e92e: 8320945: problemlist tests failing on latest Windows 11 update
  • 2584bf8: 8210410: Refactor java.util.Currency:i18n shell tests to plain java tests
  • 454b116: 8320942: Only set openjdk-target when cross compiling linux-aarch64
  • eb44baf: 8320937: support latest VS2022 MSC_VER in abstract_vm_version.cpp
  • ... and 37 more: https://git.openjdk.org/jdk/compare/4bcda602668835c35e2ac6ff6702d15cd249bc2a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 29, 2023
Copy link
Member

@magicus magicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shipilev
Copy link
Member Author

Thanks!

/integrate

@openjdk
Copy link

openjdk bot commented Nov 30, 2023

Going to push as commit 6941369.
Since your change was applied there have been 47 commits pushed to the master branch:

  • 0d14636: 8320515: assert(monitor->object_peek() != nullptr) failed: Owned monitors should not have a dead object
  • d6b4aa0: 8318157: RISC-V: implement ensureMaterializedForStackWalk intrinsic
  • 7766785: 8319372: C2 compilation fails with "Bad immediate dominator info"
  • 940f67c: 8318854: [macos14] Running any AWT app prints Secure coding warning
  • c864317: 8320888: Shenandoah: Enable ShenandoahVerifyOptoBarriers in debug builds
  • d1e73b1: 8318626: GetClassFields does not filter out ConstantPool.constantPoolOop field
  • ea6e92e: 8320945: problemlist tests failing on latest Windows 11 update
  • 2584bf8: 8210410: Refactor java.util.Currency:i18n shell tests to plain java tests
  • 454b116: 8320942: Only set openjdk-target when cross compiling linux-aarch64
  • eb44baf: 8320937: support latest VS2022 MSC_VER in abstract_vm_version.cpp
  • ... and 37 more: https://git.openjdk.org/jdk/compare/4bcda602668835c35e2ac6ff6702d15cd249bc2a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 30, 2023
@openjdk openjdk bot closed this Nov 30, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 30, 2023
@openjdk
Copy link

openjdk bot commented Nov 30, 2023

@shipilev Pushed as commit 6941369.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8320921-gha-parallel-hs-comp branch January 9, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
3 participants