Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8238781: [macos] jpackage tests failed due to "hdiutil: convert failed" in various ways #1687

Closed
wants to merge 1 commit into from

Conversation

sashamatveev
Copy link
Member

@sashamatveev sashamatveev commented Dec 8, 2020

This is similar issue we used to have for hdiutil create/detach, but for "convert". Added same workaround to repeat command. I also added repeat for "udifrez" command just in case.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8238781: [macos] jpackage tests failed due to "hdiutil: convert failed" in various ways

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1687/head:pull/1687
$ git checkout pull/1687

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 8, 2020

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 8, 2020
@openjdk
Copy link

openjdk bot commented Dec 8, 2020

@sashamatveev To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

@sashamatveev
Copy link
Member Author

sashamatveev commented Dec 8, 2020

/label core-libs

@openjdk openjdk bot added the core-libs label Dec 8, 2020
@openjdk
Copy link

openjdk bot commented Dec 8, 2020

@sashamatveev
The core-libs label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Dec 8, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 9, 2020

@sashamatveev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8238781: [macos] jpackage tests failed due to "hdiutil: convert failed" in various ways

Reviewed-by: herrick, asemenyuk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

  • 5f03341: 8052260: Reference.isEnqueued() spec does not match the long-standing behavior returning true iff it's in the ref queue
  • 6dd06ad: 8254996: make jdk.net.UnixDomainPrincipal a record class
  • bd22aa5: 8229862: NPE in jdk.compiler/com.sun.tools.javac.jvm.Code.emitop0(Code.java:570)
  • cf62b0a: 8257518: LogCompilation: java.lang.InternalError with JFR turned on
  • 6c69eca: 8257973: UTIL_LOOKUP_PROGS should only find executable files
  • 6eff931: 8256950: Add record attribute support to symbol generator CreateSymbols
  • f148915: 8245107: Use Unified Logging in trace_method_handle_stub()
  • 0201a33: 8255959: Timeouts in VectorConversion tests
  • d3dddb6: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow
  • 616b1f1: 8257516: define test group for manual tests
  • ... and 29 more: https://git.openjdk.java.net/jdk/compare/cef606feca805c614004357ca691418521f207e1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 9, 2020
@sashamatveev
Copy link
Member Author

sashamatveev commented Dec 9, 2020

/integrate

@openjdk openjdk bot closed this Dec 9, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 9, 2020
@openjdk
Copy link

openjdk bot commented Dec 9, 2020

@sashamatveev Since your change was applied there have been 40 commits pushed to the master branch:

  • b977a7b: 8257989: Error in gtest os_page_size_for_region_unaligned after 8257588
  • 5f03341: 8052260: Reference.isEnqueued() spec does not match the long-standing behavior returning true iff it's in the ref queue
  • 6dd06ad: 8254996: make jdk.net.UnixDomainPrincipal a record class
  • bd22aa5: 8229862: NPE in jdk.compiler/com.sun.tools.javac.jvm.Code.emitop0(Code.java:570)
  • cf62b0a: 8257518: LogCompilation: java.lang.InternalError with JFR turned on
  • 6c69eca: 8257973: UTIL_LOOKUP_PROGS should only find executable files
  • 6eff931: 8256950: Add record attribute support to symbol generator CreateSymbols
  • f148915: 8245107: Use Unified Logging in trace_method_handle_stub()
  • 0201a33: 8255959: Timeouts in VectorConversion tests
  • d3dddb6: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow
  • ... and 30 more: https://git.openjdk.java.net/jdk/compare/cef606feca805c614004357ca691418521f207e1...master

Your commit was automatically rebased without conflicts.

Pushed as commit e6b4c4d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs integrated
3 participants