Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257887: java/foreign/TestSegments.java test fails on 32-bit after JDK-8257186 #1688

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Dec 8, 2020

See here:
https://github.com/mcimadamore/jdk/runs/1460615378

$ CONF=linux-x86-server-fastdebug make images run-test TEST=java/foreign/TestSegments.java

STDERR:
Invalid maximum heap size: -Xmx4G
The specified size exceeds the maximum representable size.
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.

Adding @requires in the same form other java/foreign tests have it skips the test on 32-bit platforms.

Additional testing:

  • Affected test on Linux x86_32 (skipped now)
  • Affected test on Linux x86_64 (still passes)

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257887: java/foreign/TestSegments.java test fails on 32-bit after JDK-8257186

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1688/head:pull/1688
$ git checkout pull/1688

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 8, 2020

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 8, 2020
@openjdk
Copy link

openjdk bot commented Dec 8, 2020

@shipilev The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Dec 8, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 8, 2020

Webrevs

@DamonFool
Copy link
Member

The original test doesn't seem to be designed for 64-bit platforms only.
So it may not a good idea to skip it for 32-bit platforms.
Thanks.

Copy link
Member

@DamonFool DamonFool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is brittle on 32-bit platforms (see #1689 ).
I agree with @shipilev .

@shipilev
Copy link
Member Author

shipilev commented Dec 8, 2020

Thanks folks! I need a formal Reviewer ack. @mcimadamore? This would make GH testing clean again.

cl4es
cl4es approved these changes Dec 8, 2020
@openjdk
Copy link

openjdk bot commented Dec 8, 2020

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257887: java/foreign/TestSegments.java test fails on 32-bit after JDK-8257186

Reviewed-by: jiefu, adityam, redestad

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • b29f9cd: 8075778: Add javadoc tag to avoid duplication of return information in simple situations.
  • 48d8650: 8257845: Integrate JEP 390
  • ed4c4ee: 8256299: Implement JEP 396: Strongly Encapsulate JDK Internals by Default
  • c47ab5f: 8256515: javax.xml.XMLEventReader produces incorrect START_DOCUMENT event
  • 291ba97: 8251267: CDS tests should use CDSTestUtils.getOutputDir instead of System.getProperty("user.dir")
  • f48d5d1: 8257789: Fix incremental build of test-image and bundles
  • 1a9ed92: 8200102: NativeLibraryTest.java fails intermittently, unloaded count is not same as expected
  • 264feb3: 8257905: Make fixpath.sh more liberal in accepting paths embedded in arguments
  • 044616b: 8252049: Native memory leak in ciMethodData ctor
  • fab6158: 8236413: AbstractConnectTimeout should tolerate both NoRouteToHostException and UnresolvedAddressException
  • ... and 7 more: https://git.openjdk.java.net/jdk/compare/51ac37686c5a9711143131881b146751c9273a73...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 8, 2020
@shipilev
Copy link
Member Author

shipilev commented Dec 9, 2020

/integrate

@openjdk openjdk bot closed this Dec 9, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 9, 2020
@openjdk
Copy link

openjdk bot commented Dec 9, 2020

@shipilev Since your change was applied there have been 19 commits pushed to the master branch:

  • 10da767: 8257847: Tiered should publish MDO data pointer for interpreter after profile start
  • 2a62d5d: 8256917: Use combo @returns tag in java.compiler javadoc
  • b29f9cd: 8075778: Add javadoc tag to avoid duplication of return information in simple situations.
  • 48d8650: 8257845: Integrate JEP 390
  • ed4c4ee: 8256299: Implement JEP 396: Strongly Encapsulate JDK Internals by Default
  • c47ab5f: 8256515: javax.xml.XMLEventReader produces incorrect START_DOCUMENT event
  • 291ba97: 8251267: CDS tests should use CDSTestUtils.getOutputDir instead of System.getProperty("user.dir")
  • f48d5d1: 8257789: Fix incremental build of test-image and bundles
  • 1a9ed92: 8200102: NativeLibraryTest.java fails intermittently, unloaded count is not same as expected
  • 264feb3: 8257905: Make fixpath.sh more liberal in accepting paths embedded in arguments
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/51ac37686c5a9711143131881b146751c9273a73...master

Your commit was automatically rebased without conflicts.

Pushed as commit 9ce3d80.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mcimadamore
Copy link
Contributor

mcimadamore commented Dec 9, 2020

Lowering the mx size to 3G works - and I believe should work on 32bits too? Disabling the entire test seems a bit overkill IMHO.

@DamonFool
Copy link
Member

Lowering the mx size to 3G works - and I believe should work on 32bits too? Disabling the entire test seems a bit overkill IMHO.

I think -Xmx3G may be still easily broken on some 32-bit platforms since 3G >> 3800 / 2 =1900M.

@shipilev shipilev deleted the JDK-8257887-foreign-32bit branch Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
5 participants