Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321013: Parallel: Refactor ObjectStartArray #16884

Closed
wants to merge 2 commits into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Nov 29, 2023

Port the block-offset-table algorithm from Serial/G1 to Parallel.

There is ~20% reduction in young-gc pause, using card_scan.java from https://bugs.openjdk.org/browse/JDK-8310031


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8321013: Parallel: Refactor ObjectStartArray (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16884/head:pull/16884
$ git checkout pull/16884

Update a local copy of the PR:
$ git checkout pull/16884
$ git pull https://git.openjdk.org/jdk.git pull/16884/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16884

View PR using the GUI difftool:
$ git pr show -t 16884

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16884.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 29, 2023

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8321013 8321013: Parallel: Refactor ObjectStartArray Nov 29, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 29, 2023
@openjdk
Copy link

openjdk bot commented Nov 29, 2023

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Nov 29, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 29, 2023

Webrevs

@albertnetymk albertnetymk marked this pull request as draft December 4, 2023 14:11
@albertnetymk albertnetymk marked this pull request as ready for review December 4, 2023 14:12
Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

It would be nice to consolidate the three implementations (Serial, Parallel and G1) as they differ in details in a separate CR.

@openjdk
Copy link

openjdk bot commented Dec 5, 2023

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321013: Parallel: Refactor ObjectStartArray

Reviewed-by: tschatzl, sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 7fbfb3b: 8321369: Unproblemlist gc/cslocker/TestCSLocker.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 5, 2023
Copy link
Contributor

@kstefanj kstefanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Dec 6, 2023

Going to push as commit 50baaf4.
Since your change was applied there have been 15 commits pushed to the master branch:

  • afb8964: 8320443: [macos] Test java/awt/print/PrinterJob/PrinterDevice.java fails on macOS
  • 82796bd: 8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters
  • 781775d: 8321484: Make TestImplicitlyDeclaredClasses release independent
  • b02fc86: 8321122: Shenandoah: Remove ShenandoahLoopOptsAfterExpansion flag
  • 2830dd2: 8321410: Shenandoah: Remove ShenandoahSuspendibleWorkers flag
  • f482260: 8319969: os::large_page_init() turns off THPs for ZGC
  • 3edc24a: 8321073: Defer policy of disabling annotation processing by default
  • dc9c77b: 8318756: Create better internal buffer for AEADs
  • a9cb120: 8320948: NPE due to unreported compiler error
  • 4ef24e2: 8319938: TestFileChooserSingleDirectorySelection.java fails with "getSelectedFiles returned empty array"
  • ... and 5 more: https://git.openjdk.org/jdk/compare/2678e4cd9424ca4e33ebb9693c84f9a86bf5504c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 6, 2023
@openjdk openjdk bot closed this Dec 6, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 6, 2023
@openjdk
Copy link

openjdk bot commented Dec 6, 2023

@albertnetymk Pushed as commit 50baaf4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the pgc-bot branch December 7, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants