8320860: add-opens/add-exports require '=' in JAVA_TOOL_OPTIONS

[dholmes-ora]

Please review this simple clarification to the JVM TI spec regarding use of JAVA_TOOL_OPTIONS in regards to module options and their format.

I do not believe this clarification needs a CSR request.

Thanks.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8320860: add-opens/add-exports require '=' in JAVA_TOOL_OPTIONS (Bug - P4)

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16896/head:pull/16896
$ git checkout pull/16896

Update a local copy of the PR:
$ git checkout pull/16896
$ git pull https://git.openjdk.org/jdk.git pull/16896/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16896

View PR using the GUI difftool:
$ git pr show -t 16896

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16896.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dholmes-ora The following labels will be automatically applied to this pull request:

• hotspot
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (7cb6f439)
• 01: Full - Incremental (5417a109)
• 00: Full (7c8ca438)

[dholmes-ora]

/label remove hotspot

[openjdk]

@dholmes-ora
The hotspot label was successfully removed.

[AlanBateman]

I do not believe this clarification needs a CSR request.

I agree, there isn't any new testable assertion here as it is already in the JNI spec.

[sspitsyn]

The fix looks okay to me modulo Alan's suggestion to consider using the JNI version.

[sspitsyn]

David, thank you for fixing this!

[openjdk]

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320860: add-opens/add-exports require '=' in JAVA_TOOL_OPTIONS

Reviewed-by: sspitsyn, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

• aec3865: 8320697: RISC-V: Small refactoring for runtime calls
• 50d1839: 8318809: java/util/concurrent/ConcurrentLinkedQueue/WhiteBox.java shows intermittent failures on linux ppc64le and aarch64
• 81484d8: 8320687: sun.jvmstat.monitor.MonitoredHost.getMonitoredHost() throws unexpected exceptions when invoked concurrently
• 30b5d42: 8321069: JvmtiThreadState::state_for_while_locked() returns nullptr for an attached JNI thread with a java.lang.Thread object after JDK-8319935
• bd04f91: 8321131: Console read line with zero out should zero out underlying buffer in JLine
• 155abc5: 8311906: Improve robustness of String constructors with mutable array inputs
• 316b783: 8321276: runtime/cds/appcds/dynamicArchive/DynamicSharedSymbols.java failed with "'17 2: jdk/test/lib/apps ' missing from stdout/stderr"
• 65be5e0: 8305931: jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java failed with "Expected chains but found none"
• f6be922: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak
• a9de5c7: 8315128: jdk/jfr/event/runtime/TestResidentSetSizeEvent.java fails with "The size should be less than or equal to peak"
• ... and 12 more: https://git.openjdk.org/jdk/compare/b9df827adc92cb1fc65f6b1efdf82dcae00a4e2d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[AlanBateman]

Thanks, this is very clear now.

[dholmes-ora]

Thanks Alan.

/integrate

[openjdk]

Going to push as commit c8fa758.
Since your change was applied there have been 45 commits pushed to the master branch:

• 9e57010: 8315149: Add hsperf counters for CPU time of internal GC threads
• b0d1450: 8321053: Use ByteArrayInputStream.buf directly when parameter of transferTo() is trusted
• acaf2c8: 8318590: JButton ignores margin when painting HTML text
• d3df3eb: 8294699: Launcher causes lingering busy cursor
• fddc02e: 8321225: [JVMCI] HotSpotResolvedObjectTypeImpl.isLeafClass shouldn't create strong references
• 640d7f3: 8314327: Issues with JShell when using "local" execution engine
• db5613a: 8317288: [macos] java/awt/Window/Grab/GrabTest.java: Press on the outside area didn't cause ungrab
• b1cb374: 8320349: Simplify FileChooserSymLinkTest.java by using single-window testUI
• 18c7922: 8321224: ct.sym for JDK 22 contains references to internal modules
• 83ffc1a: 8320303: Allow PassFailJFrame to accept single window creator
• ... and 35 more: https://git.openjdk.org/jdk/compare/b9df827adc92cb1fc65f6b1efdf82dcae00a4e2d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dholmes-ora Pushed as commit c8fa758.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.