From 7c8ca438fc6a8f10e3cf358a26d3722e9efe7155 Mon Sep 17 00:00:00 2001 From: David Holmes Date: Wed, 29 Nov 2023 23:27:42 -0500 Subject: [PATCH 1/3] 8320860: add-opens/add-exports require '=' in JAVA_TOOL_OPTIONS --- src/hotspot/share/prims/jvmti.xml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/hotspot/share/prims/jvmti.xml b/src/hotspot/share/prims/jvmti.xml index a34a6b34573c3..e5099bd042a08 100644 --- a/src/hotspot/share/prims/jvmti.xml +++ b/src/hotspot/share/prims/jvmti.xml @@ -742,7 +742,10 @@ Agent_OnUnload_L(JavaVM *vm)
  • The pair of quote marks is not included in the option.
    • JNI_CreateJavaVM (in the JNI Invocation API) will prepend these options to the options supplied - in its JavaVMInitArgs argument. Platforms may disable this feature in cases where security is + in its JavaVMInitArgs argument. Note that module related options must be expressed in their + "option=value" form (not "option value") for JNI_CreateJavaVM to process them correctly. +

    + Platforms may disable this feature in cases where security is a concern; for example, the Reference Implementation disables this feature on Unix systems when the effective user or group ID differs from the real ID. This feature is intended to support the initialization of tools -- specifically including the From 5417a1097f7c3e70951e03aab1cbcdbc037b640e Mon Sep 17 00:00:00 2001 From: David Holmes Date: Mon, 4 Dec 2023 04:46:34 +0000 Subject: [PATCH 2/3] Change form -> format --- src/hotspot/share/prims/jvmti.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/hotspot/share/prims/jvmti.xml b/src/hotspot/share/prims/jvmti.xml index e5099bd042a08..3950f72360f4a 100644 --- a/src/hotspot/share/prims/jvmti.xml +++ b/src/hotspot/share/prims/jvmti.xml @@ -743,7 +743,7 @@ Agent_OnUnload_L(JavaVM *vm) JNI_CreateJavaVM (in the JNI Invocation API) will prepend these options to the options supplied in its JavaVMInitArgs argument. Note that module related options must be expressed in their - "option=value" form (not "option value") for JNI_CreateJavaVM to process them correctly. + "option=value" format (not "option value") for JNI_CreateJavaVM to process them correctly.

    Platforms may disable this feature in cases where security is a concern; for example, the Reference Implementation disables this feature on Unix systems when @@ -11038,7 +11038,7 @@ myInit() { vs ). An implementation is not required to support this function - when the current thread is a virtual thread, in which case + when the current thread is a virtual thread, in which case will be returned. On many platforms this call will be equivalent to: From 7cb6f439f48c09c8e6a525a04c4ad405f1cac278 Mon Sep 17 00:00:00 2001 From: David Holmes Date: Mon, 4 Dec 2023 23:40:44 +0000 Subject: [PATCH 3/3] reviewer feedback --- src/hotspot/share/prims/jvmti.xml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/hotspot/share/prims/jvmti.xml b/src/hotspot/share/prims/jvmti.xml index 3950f72360f4a..9954a6a27095a 100644 --- a/src/hotspot/share/prims/jvmti.xml +++ b/src/hotspot/share/prims/jvmti.xml @@ -743,7 +743,8 @@ Agent_OnUnload_L(JavaVM *vm) JNI_CreateJavaVM (in the JNI Invocation API) will prepend these options to the options supplied in its JavaVMInitArgs argument. Note that module related options must be expressed in their - "option=value" format (not "option value") for JNI_CreateJavaVM to process them correctly. + "option=value" format (note the required '=' between "option" and "value") for JNI_CreateJavaVM + to process them correctly.

    Platforms may disable this feature in cases where security is a concern; for example, the Reference Implementation disables this feature on Unix systems when