Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321063: AArch64: Zero build fails after JDK-8320368 #16897

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Nov 30, 2023

Simple: we need a definition for Zero, because we cannot reach the AArch64-specific one in src/cpu/aarch64.

Additional testing:

  • MacOS AArch64 Zero build now passes
  • Extensive build matrix of Zero and Server builds

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8321063: AArch64: Zero build fails after JDK-8320368 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16897/head:pull/16897
$ git checkout pull/16897

Update a local copy of the PR:
$ git checkout pull/16897
$ git pull https://git.openjdk.org/jdk.git pull/16897/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16897

View PR using the GUI difftool:
$ git pr show -t 16897

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16897.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 30, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 30, 2023

@shipilev The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Nov 30, 2023
@shipilev shipilev marked this pull request as ready for review November 30, 2023 09:18
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 30, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 30, 2023

Webrevs

@tstuefe
Copy link
Member

tstuefe commented Nov 30, 2023

Oh, you were faster than me. I'll close #16898.

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good + trivial.

@openjdk
Copy link

openjdk bot commented Nov 30, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321063: AArch64: Zero build fails after JDK-8320368

Reviewed-by: stuefe, haosun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 6941369: 8320921: GHA: Parallelize hotspot_compiler test jobs
  • 0d14636: 8320515: assert(monitor->object_peek() != nullptr) failed: Owned monitors should not have a dead object

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 30, 2023
@shipilev
Copy link
Member Author

Oh, you were faster than me. I'll close #16898.

Sorry! I thought I would get this off your plate, given how easy it is to build all Zero builds for me :)

@tstuefe
Copy link
Member

tstuefe commented Nov 30, 2023

Oh, you were faster than me. I'll close #16898.

Sorry! I thought I would get this off your plate, given how easy it is to build all Zero builds for me :)

No problem at all :-)

Copy link
Contributor

@shqking shqking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your fix.
As I tested locally, Linux AArch64 Zero build passes now.

@shipilev
Copy link
Member Author

Extensive matrix of Zero/Server builds passes for me locally. I am integrating now under triviality rule.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 30, 2023

Going to push as commit 8b102ed.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 6941369: 8320921: GHA: Parallelize hotspot_compiler test jobs
  • 0d14636: 8320515: assert(monitor->object_peek() != nullptr) failed: Owned monitors should not have a dead object

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 30, 2023
@openjdk openjdk bot closed this Nov 30, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 30, 2023
@openjdk
Copy link

openjdk bot commented Nov 30, 2023

@shipilev Pushed as commit 8b102ed.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8321063-zero-build-failures branch January 9, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
3 participants