Skip to content

8260861: TrustStoreDescriptor log the same value #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

8260861: TrustStoreDescriptor log the same value #1690

wants to merge 1 commit into from

Conversation

davinkevin
Copy link
Contributor

@davinkevin davinkevin commented Dec 8, 2020 •
edited by openjdk bot
Loading

If both jssecacerts and cacerts are not defined, the same log is printed twice, talking about the jssecacerts instead of cacerts the second time. 

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1690/head:pull/1690
$ git checkout pull/1690

@davinkevin
fix(truststore): log about truststore not found print everytime the s…
9218f07 
…ame value

If the both `jssecacerts` and `cacerts` is not defined, the same log is print twice, talking about the `jssecacerts` instead of `cacerts` the second time.
@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Dec 8, 2020
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 8, 2020

Hi @davinkevin, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user davinkevin" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Dec 8, 2020

@davinkevin The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Dec 8, 2020
@davinkevin
Copy link
Contributor Author

/signed

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Dec 8, 2020
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 8, 2020

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Dec 10, 2020
@davinkevin
Copy link
Contributor Author

OCA has been signed and my name has been added into the OCA listing page:

What is the next step to make this contribution eligible to merge ?

@davinkevin
Copy link
Contributor Author

/signed

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 1, 2021

You are already a known contributor!

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 29, 2021

@davinkevin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@davinkevin
Copy link
Contributor Author

I've made all the tasks required, so I don't know why the process is blocked 😓.

@XueleiFan
Copy link
Member

/issue JDK-8260861

@openjdk
Copy link

openjdk bot commented Feb 1, 2021

@XueleiFan Only the author (@davinkevin) is allowed to issue the /issue command.

@davinkevin
Copy link
Contributor Author

/issue JDK-8260861

@openjdk openjdk bot changed the title fix(truststore): log about truststore not found print everytime the same value 8260861: TrustStoreDescriptor log the same value Feb 1, 2021
@openjdk
Copy link

openjdk bot commented Feb 1, 2021

@davinkevin The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

@openjdk
Copy link

openjdk bot commented Feb 1, 2021 •
edited
Loading

@davinkevin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260861: TrustStoreDescriptor log the same value

Reviewed-by: xuelei

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 718 new commits pushed to the master branch:

  • 69189f8: 8256421: Add 2 HARICA roots to cacerts truststore
  • f546fd0: 8260902: CDS mapping errors should not lead to unconditional output
  • d7b1fc5: 8260707: java/lang/instrument/PremainClass/InheritAgent0100.java times out
  • 0093183: 8260368: [PPC64] GC interface needs enhancement to support GCs with load barriers
  • defcb04: 8260867: ProblemList java/awt/FullScreen/TranslucentWindow/TranslucentWindow.java on linux
  • a421bfa: 8259839: SystemDictionary exports too much implementation
  • 189b65b: 8260264: Move common os_ inline methods to a common posix source file
  • 288a4fe: 8260643: Remove parallel version handling in CardTableRS::younger_refs_in_space_iterate()
  • ddd2951: 8260571: Add PrintMetaspaceStatistics to print metaspace statistics upon VM exit
  • fe407cf: 8260420: C2 compilation fails with assert(found_sfpt) failed: no node in loop that's not input to safepoint
  • ... and 708 more: https://git.openjdk.java.net/jdk/compare/1d0adbb812bc4b40fb614f245dd8ed2ef66ff073...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@XueleiFan) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 1, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 1, 2021

Webrevs

@davinkevin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 2, 2021
@openjdk
Copy link

openjdk bot commented Feb 2, 2021

@davinkevin
Your change (at version 9218f07) is now ready to be sponsored by a Committer.

@XueleiFan
Copy link
Member

/sponsor

@openjdk openjdk bot closed this Feb 2, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 2, 2021
@openjdk
Copy link

openjdk bot commented Feb 2, 2021

@XueleiFan @davinkevin Since your change was applied there have been 718 commits pushed to the master branch:

  • 69189f8: 8256421: Add 2 HARICA roots to cacerts truststore
  • f546fd0: 8260902: CDS mapping errors should not lead to unconditional output
  • d7b1fc5: 8260707: java/lang/instrument/PremainClass/InheritAgent0100.java times out
  • 0093183: 8260368: [PPC64] GC interface needs enhancement to support GCs with load barriers
  • defcb04: 8260867: ProblemList java/awt/FullScreen/TranslucentWindow/TranslucentWindow.java on linux
  • a421bfa: 8259839: SystemDictionary exports too much implementation
  • 189b65b: 8260264: Move common os_ inline methods to a common posix source file
  • 288a4fe: 8260643: Remove parallel version handling in CardTableRS::younger_refs_in_space_iterate()
  • ddd2951: 8260571: Add PrintMetaspaceStatistics to print metaspace statistics upon VM exit
  • fe407cf: 8260420: C2 compilation fails with assert(found_sfpt) failed: no node in loop that's not input to safepoint
  • ... and 708 more: https://git.openjdk.java.net/jdk/compare/1d0adbb812bc4b40fb614f245dd8ed2ef66ff073...master

Your commit was automatically rebased without conflicts.

Pushed as commit 105d3e8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XueleiFan XueleiFan XueleiFan approved these changes

Assignees
No one assigned
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davinkevin @XueleiFan