8227529: With malformed --app-image the error messages are awful

[alexeysemenyukoracle]

Add tests to make sure jpackage emits meaningful error messages when used with invalid app images.

Added JPackageCommand.nullableOutputBundle() function that returns an empty Optional instance if it fails to deduce a path to the output bundle from jpackage command line. This is the case when jpackage command is used with --app-image cli option and referenced app image directory is missing .jpackage.xml file.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8227529: With malformed --app-image the error messages are awful (Bug - P4)

Reviewers

• Alexander Matveev (@sashamatveev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16901/head:pull/16901
$ git checkout pull/16901

Update a local copy of the PR:
$ git checkout pull/16901
$ git pull https://git.openjdk.org/jdk.git pull/16901/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16901

View PR using the GUI difftool:
$ git pr show -t 16901

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16901.diff

Webrev

Link to Webrev Comment

[alexeysemenyukoracle]

@sashamatveev please review

[bridgekeeper]

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5a2ee8e4)

[sashamatveev]

Looks good.

[openjdk]

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8227529: With malformed --app-image the error messages are awful

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

• c4732c2: 8320530: has_resolved_ref_index flag not restored after resetting entry
• e96e191: 8318586: Explicitly handle upcall stub allocation failure
• 630bafd: 8320826: call allocate_shared_strings_array after all strings are interned
• 0a60b0f: 8302233: HSS/LMS: keytool and jarsigner changes
• 7ad7005: 8315034: File.mkdirs() occasionally fails to create folders on Windows shared folder
• 41daa3b: 8320239: add dynamic switch for JvmtiVTMSTransitionDisabler sync protocol
• 7c135c3: 8321066: Multiple JFR tests have started failing
• 8bedb28: 8321119: Disable java/foreign/TestHandshake.java on Zero VMs
• b1cbf55: 8321018: Parallel: Make some methods in ParCompactionManager private
• c6a8278: 8321127: ProblemList java/util/stream/GatherersTest.java
• ... and 16 more: https://git.openjdk.org/jdk/compare/c86431767e6802317dc2be6221a5d0990b976ddc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[alexeysemenyukoracle]

/integrate

[openjdk]

Going to push as commit 56d4c33.
Since your change was applied there have been 27 commits pushed to the master branch:

• 76fea80: 8320608: Many jtreg printing tests are missing the @printer keyword
• c4732c2: 8320530: has_resolved_ref_index flag not restored after resetting entry
• e96e191: 8318586: Explicitly handle upcall stub allocation failure
• 630bafd: 8320826: call allocate_shared_strings_array after all strings are interned
• 0a60b0f: 8302233: HSS/LMS: keytool and jarsigner changes
• 7ad7005: 8315034: File.mkdirs() occasionally fails to create folders on Windows shared folder
• 41daa3b: 8320239: add dynamic switch for JvmtiVTMSTransitionDisabler sync protocol
• 7c135c3: 8321066: Multiple JFR tests have started failing
• 8bedb28: 8321119: Disable java/foreign/TestHandshake.java on Zero VMs
• b1cbf55: 8321018: Parallel: Make some methods in ParCompactionManager private
• ... and 17 more: https://git.openjdk.org/jdk/compare/c86431767e6802317dc2be6221a5d0990b976ddc...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexeysemenyukoracle Pushed as commit 56d4c33.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.