Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321114: Rename "Unnamed Classes" to "Implicitly Declared Classes" better #16904

Closed
wants to merge 2 commits into from

Conversation

pavelrappo
Copy link
Member

@pavelrappo pavelrappo commented Nov 30, 2023

Please review this PR to correctly rename "Unnamed Class" to "Implicitly Declared Class", not "Implicit Class".

Renaming is fixed where it affects documentation or the end-user. Renaming is not fixed where it only affects code: it's perfectly okay to derive an internal element name from "Implicit Class" rather than "Implicitly Declared Class", for brevity.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8321114: Rename "Unnamed Classes" to "Implicitly Declared Classes" better (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16904/head:pull/16904
$ git checkout pull/16904

Update a local copy of the PR:
$ git checkout pull/16904
$ git pull https://git.openjdk.org/jdk.git pull/16904/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16904

View PR using the GUI difftool:
$ git pr show -t 16904

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16904.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 30, 2023

👋 Welcome back prappo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 30, 2023
@openjdk
Copy link

openjdk bot commented Nov 30, 2023

@pavelrappo The following labels will be automatically applied to this pull request:

  • compiler
  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org compiler compiler-dev@openjdk.org labels Nov 30, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 30, 2023

Webrevs

Copy link
Member

@JimLaskey JimLaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Nov 30, 2023

@pavelrappo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321114: Rename "Unnamed Classes" to "Implicitly Declared Classes" better

Reviewed-by: jlaskey

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • ecd335d: 8321107: Add more test cases for JDK-8319372
  • 2476be4: 8320716: ResolvedModule::reads includes self when configuration contains two or more automatic modules
  • 4ba94ef: 8320145: Compiler should accept final variable in Record Pattern
  • 02ffab1: 8321141: VM build issue on MacOS after JDK-8267532
  • 56d4c33: 8227529: With malformed --app-image the error messages are awful
  • 76fea80: 8320608: Many jtreg printing tests are missing the @printer keyword
  • c4732c2: 8320530: has_resolved_ref_index flag not restored after resetting entry
  • e96e191: 8318586: Explicitly handle upcall stub allocation failure
  • 630bafd: 8320826: call allocate_shared_strings_array after all strings are interned
  • 0a60b0f: 8302233: HSS/LMS: keytool and jarsigner changes
  • ... and 11 more: https://git.openjdk.org/jdk/compare/04ad98ed32cf899404a3ae13e24407e53be7ebc6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 30, 2023
@pavelrappo
Copy link
Member Author

pavelrappo commented Dec 1, 2023

@JimLaskey please re-review this PR due to a newly pushed 3676b50. Also, please double-check if the comment is still valid factually.

@pavelrappo
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 1, 2023

Going to push as commit 8f1d40b.
Since your change was applied there have been 21 commits pushed to the master branch:

  • ecd335d: 8321107: Add more test cases for JDK-8319372
  • 2476be4: 8320716: ResolvedModule::reads includes self when configuration contains two or more automatic modules
  • 4ba94ef: 8320145: Compiler should accept final variable in Record Pattern
  • 02ffab1: 8321141: VM build issue on MacOS after JDK-8267532
  • 56d4c33: 8227529: With malformed --app-image the error messages are awful
  • 76fea80: 8320608: Many jtreg printing tests are missing the @printer keyword
  • c4732c2: 8320530: has_resolved_ref_index flag not restored after resetting entry
  • e96e191: 8318586: Explicitly handle upcall stub allocation failure
  • 630bafd: 8320826: call allocate_shared_strings_array after all strings are interned
  • 0a60b0f: 8302233: HSS/LMS: keytool and jarsigner changes
  • ... and 11 more: https://git.openjdk.org/jdk/compare/04ad98ed32cf899404a3ae13e24407e53be7ebc6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 1, 2023
@openjdk openjdk bot closed this Dec 1, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 1, 2023
@openjdk
Copy link

openjdk bot commented Dec 1, 2023

@pavelrappo Pushed as commit 8f1d40b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants