8321119: Disable java/foreign/TestHandshake.java on Zero VMs

[JornVernee]

This test is problematic on Zero due to https://bugs.openjdk.org/browse/JDK-8321064

Disable it for now on that platform, until a Zero maintainer has a chance to look into it.

Testing: running TestHandshake on zero to see that it is skipped.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8321119: Disable java/foreign/TestHandshake.java on Zero VMs (Bug - P4)

Reviewers

• Erik Österlund (@fisk - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16906/head:pull/16906
$ git checkout pull/16906

Update a local copy of the PR:
$ git checkout pull/16906
$ git pull https://git.openjdk.org/jdk.git pull/16906/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16906

View PR using the GUI difftool:
$ git pr show -t 16906

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16906.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@JornVernee The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[fisk]

Looks good.

[openjdk]

@JornVernee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321119: Disable java/foreign/TestHandshake.java on Zero VMs

Reviewed-by: eosterlund, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• c6a8278: 8321127: ProblemList java/util/stream/GatherersTest.java
• a3eb664: 8315701: [macos] Regression: KeyEvent has different keycode on different keyboard layouts
• 6aba6aa: 8320347: Emulate vblendvp[sd] on ECore
• 6938474: 8320916: jdk/jfr/event/gc/stacktrace/TestParallelMarkSweepAllocationPendingStackTrace.java failed with "OutOfMemoryError: GC overhead limit exceeded"
• da09eab: 8319980: [JVMCI] libgraal should reuse Thread instances as C2 does
• 33b26f7: 8319123: Implement JEP 461: Stream Gatherers (Preview)
• 04ad98e: 8315458: Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview)
• 03759e8: 8320304: Refactor and simplify monitor deflation functions
• da7cf25: 8320665: update jdk_core at open/test/jdk/TEST.groups
• c9d15f7: 8321025: Enable Neoverse N1 optimizations for Neoverse V2
• ... and 1 more: https://git.openjdk.org/jdk/compare/8b102ed6b4f595f07c0e741328f5fcac65320461...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Hold on, can we figure out if Zero can actually be fixed before we go and disable the test? I think we only disable the tests like this if there is an intrinsic reason why the test does not apply to a platform.

[mlbridge]

Webrevs

• 00: Full (5c4a1fc2)

[JornVernee]

Hold on, can we figure out if Zero can actually be fixed before we go and disable the test? I think we only disable the tests like this if there is an intrinsic reason why the test does not apply to a platform.

I would problem list it, but we can't problem list tests specifically on Zero.

The issue seems to be in Zero not polling for safepoints enough. See some discussion on: https://bugs.openjdk.org/browse/JDK-8321064

[shipilev]

Hold on, can we figure out if Zero can actually be fixed before we go and disable the test? I think we only disable the tests like this if there is an intrinsic reason why the test does not apply to a platform.

I would problem list it, but we can't problem list tests specifically on Zero.

Ah, that is unfortunate. Lacking problem-list support, disabling the test with @requires is okay.

[JornVernee]

Thanks for the reviews. I'll integrate this since it's trivial, and to quiet CI.

[JornVernee]

/integrate

[openjdk]

Going to push as commit 8bedb28.
Since your change was applied there have been 12 commits pushed to the master branch:

• b1cbf55: 8321018: Parallel: Make some methods in ParCompactionManager private
• c6a8278: 8321127: ProblemList java/util/stream/GatherersTest.java
• a3eb664: 8315701: [macos] Regression: KeyEvent has different keycode on different keyboard layouts
• 6aba6aa: 8320347: Emulate vblendvp[sd] on ECore
• 6938474: 8320916: jdk/jfr/event/gc/stacktrace/TestParallelMarkSweepAllocationPendingStackTrace.java failed with "OutOfMemoryError: GC overhead limit exceeded"
• da09eab: 8319980: [JVMCI] libgraal should reuse Thread instances as C2 does
• 33b26f7: 8319123: Implement JEP 461: Stream Gatherers (Preview)
• 04ad98e: 8315458: Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview)
• 03759e8: 8320304: Refactor and simplify monitor deflation functions
• da7cf25: 8320665: update jdk_core at open/test/jdk/TEST.groups
• ... and 2 more: https://git.openjdk.org/jdk/compare/8b102ed6b4f595f07c0e741328f5fcac65320461...master

Your commit was automatically rebased without conflicts.

[openjdk]

@JornVernee Pushed as commit 8bedb28.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.