8310711: [IR Framework] Remove safepoint while printing handling

[chhagedorn]

This clean-up PR removes the handling of the <!-- safepoint while printing --> message in the IR framework. It is no longer required since we dump the output of PrintIdeal to the hotspot_pid file differently since JDK-8306922. There is no interrupting <!-- safepoint while printing --> message anymore. I removed the corresponding now unneeded code together with the previously added test case for it.

Testing: tier1-4

Thanks,
Christian

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8310711: [IR Framework] Remove safepoint while printing handling (Enhancement - P4)

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer)
• Emanuel Peter (@eme64 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16921/head:pull/16921
$ git checkout pull/16921

Update a local copy of the PR:
$ git checkout pull/16921
$ git pull https://git.openjdk.org/jdk.git pull/16921/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16921

View PR using the GUI difftool:
$ git pr show -t 16921

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16921.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back chagedorn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@chhagedorn The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (38f00cc3)
• 00: Full (ed5ef1fd)

[TobiHartmann]

Nice cleanup, looks good to me.

[openjdk]

@chhagedorn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310711: [IR Framework] Remove safepoint while printing handling

Reviewed-by: thartmann, epeter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

• a40d397: 8323110: Eliminate -Wparentheses warnings in ppc code
• 7edd10e: 8321786: SegmentAllocator:allocateFrom(ValueLayout, MemorySegment,ValueLayout,long,long) spec mismatch in exception scenario
• d75d876: 8322806: Eliminate -Wparentheses warnings in aarch64 code
• e442769: 8322754: click JComboBox when dialog about to close causes IllegalComponentStateException
• 3560e68: 8322815: Eliminate -Wparentheses warnings in shenandoah code
• faa9c69: 8322846: Running with -Djdk.tracePinnedThreads set can hang
• ace010b: 8319757: java/nio/channels/DatagramChannel/InterruptibleOrNot.java failed: wrong exception thrown
• be4614e: 8323016: Improve reporting for bad options
• 35a1b77: 8322636: [JVMCI] HotSpotSpeculationLog can be inconsistent across a single compile
• 46965a0: 8322981: Fix 2 locations in JDI that throw IOException without using the "Caused by" exception
• ... and 44 more: https://git.openjdk.org/jdk/compare/9ab29f8dcd1c0092e4251f996bd53c704e87a74a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[chhagedorn]

Thanks Tobias for your review!

[eme64]

Thanks for the cleanup @chhagedorn , LGTM!

[chhagedorn]

Thanks Emanuel for your review! I will integrate this in the new year when I'm back again.

[chhagedorn]

Thanks for the re-review @TobiHartmann @eme64!

/integrate

[openjdk]

Going to push as commit 458e563.
Since your change was applied there have been 57 commits pushed to the master branch:

• 71aac7a: 8276809: java/awt/font/JNICheck/FreeTypeScalerJNICheck.java shows JNI warning on Windows
• 09c6c4f: 8322489: 22-b27: Up to 7% regression in all Footprint3-*-G1/ZGC
• eb9e754: 8323065: Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination
• a40d397: 8323110: Eliminate -Wparentheses warnings in ppc code
• 7edd10e: 8321786: SegmentAllocator:allocateFrom(ValueLayout, MemorySegment,ValueLayout,long,long) spec mismatch in exception scenario
• d75d876: 8322806: Eliminate -Wparentheses warnings in aarch64 code
• e442769: 8322754: click JComboBox when dialog about to close causes IllegalComponentStateException
• 3560e68: 8322815: Eliminate -Wparentheses warnings in shenandoah code
• faa9c69: 8322846: Running with -Djdk.tracePinnedThreads set can hang
• ace010b: 8319757: java/nio/channels/DatagramChannel/InterruptibleOrNot.java failed: wrong exception thrown
• ... and 47 more: https://git.openjdk.org/jdk/compare/9ab29f8dcd1c0092e4251f996bd53c704e87a74a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@chhagedorn Pushed as commit 458e563.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.