JDK-8317307: test/jdk/com/sun/jndi/ldap/LdapPoolTimeoutTest.java fails with ConnectException: Connection timed out: no further information

[MBaesken]

On Windows we recently run into this error rather often in the test LdapPoolTimeoutTest.java :

MSG RTE: javax.naming.CommunicationException: example.com:1234 [Root exception is java.net.ConnectException: Connection timed out: no further information]
MSG: Connect timed out
MSG: Timeout exceeded while waiting for a connection: 26984ms
MSG: Timed out waiting for lock
MSG: Timed out waiting for lock
MSG: Timed out waiting for lock
MSG: Timeout exceeded while waiting for a connection: 26984ms
MSG: Timeout exceeded while waiting for a connection: 26984ms
java.lang.Exception: failures: 1
at com.sun.javatest.regtest.agent.TestNGRunner.main(TestNGRunner.java:104)
at com.sun.javatest.regtest.agent.TestNGRunner.main(TestNGRunner.java:58)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at com.sun.javatest.regtest.agent.MainWrapper$MainTask.run(MainWrapper.java:138)
at java.base/java.lang.Thread.run(Thread.java:1570)

We should extend the accepted exception message strings and also also 'Connection timed out' .

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8317307: test/jdk/com/sun/jndi/ldap/LdapPoolTimeoutTest.java fails with ConnectException: Connection timed out: no further information (Bug - P4)

Reviewers

• Christoph Langer (@RealCLanger - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16922/head:pull/16922
$ git checkout pull/16922

Update a local copy of the PR:
$ git checkout pull/16922
$ git pull https://git.openjdk.org/jdk.git pull/16922/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16922

View PR using the GUI difftool:
$ git pr show -t 16922

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16922.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0bea16c2)

[RealCLanger]

Looks good and makes sense to accept this case as well since we see it occuring in real life.
Maybe move the || msg.contains("Connection timed out") into the next line.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317307: test/jdk/com/sun/jndi/ldap/LdapPoolTimeoutTest.java fails with ConnectException: Connection timed out: no further information

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[MBaesken]

Thanks for the review !

/integrate

[openjdk]

Going to push as commit b9b8263.
Since your change was applied there have been 17 commits pushed to the master branch:

• 0d0a657: 5108458: JTable does not properly layout its content
• 2b00ac0: 8308753: Class-File API transition to Preview
• b9df827: 8309871: jdk/jfr/api/consumer/recordingstream/TestSetEndTime.java timed out
• 9498469: 8318983: Fix comment typo in PKCS12Passwd.java
• 4dcbd13: 8314905: jdk/jfr/tool/TestView.java fails with RuntimeException 'Invoked Concurrent' missing from stdout/stderr
• 5dee2a3: 8320440: Implementation of Structured Concurrency (Second Preview)
• 6f7bb79: 8320931: [REDO] dsymutil command leaves around temporary directories
• 8be3e39: 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX
• 2f299e4: 8321182: SourceExample.SOURCE_14 comment should refer to 'switch expressions' instead of 'text blocks'
• 3a09a05: 8313722: JFR: Avoid unnecessary calls to Events.from(Recording)
• ... and 7 more: https://git.openjdk.org/jdk/compare/3b30095a63bdf8224a5625507a69942210a203a0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit b9b8263.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.