8321124: java/util/stream/GatherersTest.java times out #16928

viktorklang-ora · 2023-12-01T17:00:48Z

Splits GatherersTest out to distinct files per built-in gatherer

Fixes a test ordering issue for mapConcurrent which placed GatherersTest on the ProblemList.

Adding increased maxOutputSize for Gatherer-related tests to improve debuggability.

Lowering the composition threshold of GathererTest.testMassivelyComposedGatherers to 256 to avoid SOE on low-specc:ed machines.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8321124: java/util/stream/GatherersTest.java times out (Bug - P3)

Reviewers

Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16928/head:pull/16928
$ git checkout pull/16928

Update a local copy of the PR:
$ git checkout pull/16928
$ git pull https://git.openjdk.org/jdk.git pull/16928/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16928

View PR using the GUI difftool:
$ git pr show -t 16928

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16928.diff

Webrev

Link to Webrev Comment

to BuiltInGatherersTest for easier deduplication of GathererTest. Adding increased maxOutputSize for Gatherer-related tests to improve debuggability. Lowering the composition threshold of GathererTest.testMassivelyComposedGatherers to 256 to avoid SOE on low-specc:ed machines.

bridgekeeper · 2023-12-01T17:01:45Z

👋 Welcome back vklang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-12-01T17:03:24Z

@viktorklang-ora The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

test/jdk/java/util/stream/BuiltInGatherersTest.java

mlbridge · 2023-12-01T17:06:29Z

Webrevs

…eams to conserve resources

test/jdk/java/util/stream/BuiltInGatherersTest.java

test/jdk/java/util/stream/GatherersFoldTest.java

test/jdk/java/util/stream/GatherersScanTest.java

test/jdk/java/util/stream/GatherersMapConcurrentTest.java

AlanBateman

Thanks for the updates/refactoring, I don't have any more comments to add.

openjdk · 2023-12-05T16:54:43Z

@viktorklang-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321124: java/util/stream/GatherersTest.java times out

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 58 new commits pushed to the master branch:

9e57010: 8315149: Add hsperf counters for CPU time of internal GC threads
b0d1450: 8321053: Use ByteArrayInputStream.buf directly when parameter of transferTo() is trusted
acaf2c8: 8318590: JButton ignores margin when painting HTML text
d3df3eb: 8294699: Launcher causes lingering busy cursor
fddc02e: 8321225: [JVMCI] HotSpotResolvedObjectTypeImpl.isLeafClass shouldn't create strong references
640d7f3: 8314327: Issues with JShell when using "local" execution engine
db5613a: 8317288: [macos] java/awt/Window/Grab/GrabTest.java: Press on the outside area didn't cause ungrab
b1cb374: 8320349: Simplify FileChooserSymLinkTest.java by using single-window testUI
18c7922: 8321224: ct.sym for JDK 22 contains references to internal modules
83ffc1a: 8320303: Allow PassFailJFrame to accept single window creator
... and 48 more: https://git.openjdk.org/jdk/compare/3087e14cde9257680f0406b11942f9cb7739cb7b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

vnkozlov · 2023-12-05T18:05:31Z

Thank you for fixing GHA failure.
I am not doing review since I am not expert.

turbanoff · 2023-12-05T19:17:08Z

test/jdk/java/util/stream/GatherersMapConcurrentTest.java

+                                catch (InterruptedException ie) {
+                                    fail("Unexpected!");
+                                }
+                                while(tasksWaiting.getQueueLength() < tasksToCancel) {


Suggested change

while(tasksWaiting.getQueueLength() < tasksToCancel) {

while (tasksWaiting.getQueueLength() < tasksToCancel) {

viktorklang-ora · 2023-12-05T20:15:07Z

/integrate

openjdk · 2023-12-05T20:16:30Z

@viktorklang-ora
Your change (at version 663a7b6) is now ready to be sponsored by a Committer.

AlanBateman · 2023-12-06T07:09:44Z

/sponsor

openjdk · 2023-12-06T07:12:06Z

Going to push as commit 9d77677.
Since your change was applied there have been 66 commits pushed to the master branch:

4c96aac: 8320935: Move CDS config initialization code to cdsConfig.cpp
78d0958: 8321406: Null IDs should be resolved as before catalogs are added
aaaae3e: 8321207: javac is not accepting correct code
86b27b7: 8317831: compiler/codecache/CheckLargePages.java fails on OL 8.8 with unexpected memory string
3cd65ce: 8321325: Remove unused Java_java_awt_MenuComponent_initIDs function
905137d: 8321219: runtime/jni/FastGetField: assert(is_interpreted_frame()) failed: interpreted frame expected
430564c: 8308715: Create a mechanism for Implicitly Declared Class javadoc
c8fa758: 8320860: add-opens/add-exports require '=' in JAVA_TOOL_OPTIONS
9e57010: 8315149: Add hsperf counters for CPU time of internal GC threads
b0d1450: 8321053: Use ByteArrayInputStream.buf directly when parameter of transferTo() is trusted
... and 56 more: https://git.openjdk.org/jdk/compare/3087e14cde9257680f0406b11942f9cb7739cb7b...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-12-06T07:12:13Z

@AlanBateman @viktorklang-ora Pushed as commit 9d77677.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk bot added the rfr Pull request is ready for review label Dec 1, 2023

openjdk bot added the core-libs core-libs-dev@openjdk.org label Dec 1, 2023

viktorklang-ora commented Dec 1, 2023

View reviewed changes

test/jdk/java/util/stream/BuiltInGatherersTest.java Outdated Show resolved Hide resolved

Only run the cancellation tests for mapConcurrent for the shorter str…

a4ab346

…eams to conserve resources

viktorklang-ora commented Dec 1, 2023

View reviewed changes

test/jdk/java/util/stream/BuiltInGatherersTest.java Outdated Show resolved Hide resolved

LizBing mentioned this pull request Dec 2, 2023

8234502: Merge GenCollectedHeap and SerialHeap #16927

Closed

3 tasks

AlanBateman reviewed Dec 3, 2023

View reviewed changes

Maintainability, correctness, and stability overhaul of Gatherers tests

59b82f3

viktorklang-ora commented Dec 4, 2023

View reviewed changes

test/jdk/java/util/stream/GatherersFoldTest.java Show resolved Hide resolved

Removing extraneous built-in gatherer test output

fd426ae

viktorklang-ora commented Dec 5, 2023

View reviewed changes

test/jdk/java/util/stream/GatherersScanTest.java Show resolved Hide resolved

AlanBateman reviewed Dec 5, 2023

View reviewed changes

test/jdk/java/util/stream/GatherersMapConcurrentTest.java Outdated Show resolved Hide resolved

test/jdk/java/util/stream/GatherersMapConcurrentTest.java Show resolved Hide resolved

Addressing review feedback: improving test coverage and debuggability

663a7b6

AlanBateman approved these changes Dec 5, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Dec 5, 2023

turbanoff reviewed Dec 5, 2023

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 5, 2023

openjdk bot added the integrated Pull request has been integrated label Dec 6, 2023

openjdk bot closed this Dec 6, 2023

openjdk bot removed the ready Pull request is ready to be integrated label Dec 6, 2023

openjdk bot removed rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8321124: java/util/stream/GatherersTest.java times out #16928

8321124: java/util/stream/GatherersTest.java times out #16928

viktorklang-ora commented Dec 1, 2023 •

edited by openjdk bot

Loading

bridgekeeper bot commented Dec 1, 2023

openjdk bot commented Dec 1, 2023

mlbridge bot commented Dec 1, 2023 •

edited

Loading

AlanBateman left a comment

openjdk bot commented Dec 5, 2023 •

edited

Loading

vnkozlov commented Dec 5, 2023

turbanoff Dec 5, 2023

viktorklang-ora commented Dec 5, 2023

openjdk bot commented Dec 5, 2023

AlanBateman commented Dec 6, 2023

openjdk bot commented Dec 6, 2023

openjdk bot commented Dec 6, 2023

	while(tasksWaiting.getQueueLength() < tasksToCancel) {
	while (tasksWaiting.getQueueLength() < tasksToCancel) {

8321124: java/util/stream/GatherersTest.java times out #16928

8321124: java/util/stream/GatherersTest.java times out #16928

Conversation

viktorklang-ora commented Dec 1, 2023 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Dec 1, 2023

openjdk bot commented Dec 1, 2023

mlbridge bot commented Dec 1, 2023 • edited Loading

Webrevs

AlanBateman left a comment

Choose a reason for hiding this comment

openjdk bot commented Dec 5, 2023 • edited Loading

vnkozlov commented Dec 5, 2023

turbanoff Dec 5, 2023

Choose a reason for hiding this comment

viktorklang-ora commented Dec 5, 2023

openjdk bot commented Dec 5, 2023

AlanBateman commented Dec 6, 2023

openjdk bot commented Dec 6, 2023

openjdk bot commented Dec 6, 2023

viktorklang-ora commented Dec 1, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Dec 1, 2023 •

edited

Loading

openjdk bot commented Dec 5, 2023 •

edited

Loading