Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312098: Update man page for javadoc #16929

Closed
wants to merge 1 commit into from

Conversation

pavelrappo
Copy link
Member

@pavelrappo pavelrappo commented Dec 1, 2023

Please review this forwardport.

The original issue should've been committed to mainline first and then backported to jdk21, but instead it was committed in jdk21 first and almost forgotten to be brought to mainline.

This PR brings the change to mainline just in time: RDP 1 is next week.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16929/head:pull/16929
$ git checkout pull/16929

Update a local copy of the PR:
$ git checkout pull/16929
$ git pull https://git.openjdk.org/jdk.git pull/16929/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16929

View PR using the GUI difftool:
$ git pr show -t 16929

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16929.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 1, 2023

👋 Welcome back prappo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4fcb0b28d7eda3f147432ce8d8d27f91a0805ab6 8312098: Update man page for javadoc Dec 1, 2023
@openjdk
Copy link

openjdk bot commented Dec 1, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 1, 2023
@openjdk
Copy link

openjdk bot commented Dec 1, 2023

@pavelrappo The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the javadoc javadoc-dev@openjdk.org label Dec 1, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 1, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 1, 2023

@pavelrappo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312098: Update man page for javadoc

Reviewed-by: jlaskey

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 1, 2023
@pavelrappo
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 1, 2023

Going to push as commit 92f7e51.
Since your change was applied there have been 2 commits pushed to the master branch:

  • f6be7fd: 8321059: Unneeded array assignments in MergeCollation and CompactByteArray
  • d568562: 8320798: Console read line with zero out should zero out underlying buffer

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 1, 2023
@openjdk openjdk bot closed this Dec 1, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 1, 2023
@openjdk
Copy link

openjdk bot commented Dec 1, 2023

@pavelrappo Pushed as commit 92f7e51.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org
2 participants