Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319072: JFR: Turn off events for JFR.view #16936

Closed
wants to merge 1 commit into from

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented Dec 2, 2023

Could I have a review of a change that disables events for the Attach thread when executing the diagnostic command JFR.view. The rationale is to avoid exception events etc. that create noise in the output making troubleshooting the application harder. I also removed an incorrect comment.

I'm not a fan of overrides that return boolean values, but it was hard to come up with something better without a large refactoring, or adding boilerplate code to the other diagnostic commands.

Testing: idk/jdk/jfr

Thanks
Erik


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8319072: JFR: Turn off events for JFR.view (Enhancement - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16936/head:pull/16936
$ git checkout pull/16936

Update a local copy of the PR:
$ git checkout pull/16936
$ git pull https://git.openjdk.org/jdk.git pull/16936/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16936

View PR using the GUI difftool:
$ git pr show -t 16936

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16936.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 2, 2023

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 2, 2023

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Dec 2, 2023
@egahlin egahlin marked this pull request as ready for review December 2, 2023 19:49
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 2, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 2, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 4, 2023

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319072: JFR: Turn off events for JFR.view

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 9769dfe: 8321214: Parallel: Remove unused SpaceInfo::_min_dense_prefix
  • d23f4f1: 8315559: Delay TempSymbol cleanup to avoid symbol table churn
  • c17b8cf: 8320655: awt screencast robot spin and sync issues with native libpipewire api
  • ed5b8c3: 8225220: When the Tab Policy is checked,the scroll button direction displayed incorrectly.
  • f32ab8c: 8320924: Improve heap dump performance by optimizing archived object checks
  • 93b9235: 8321120: Shenandoah: Remove ShenandoahElasticTLAB flag
  • 9b8eaa2: 8319872: AArch64: [vectorapi] Implementation of unsigned (zero extended) casts
  • b9b8263: 8317307: test/jdk/com/sun/jndi/ldap/LdapPoolTimeoutTest.java fails with ConnectException: Connection timed out: no further information
  • 0d0a657: 5108458: JTable does not properly layout its content
  • 2b00ac0: 8308753: Class-File API transition to Preview
  • ... and 2 more: https://git.openjdk.org/jdk/compare/4dcbd13f99b62de16d6ed13cdf422e6bf9b03a63...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 4, 2023
@egahlin
Copy link
Member Author

egahlin commented Dec 4, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Dec 4, 2023

Going to push as commit d2c529c.
Since your change was applied there have been 13 commits pushed to the master branch:

  • d5f59cf: 8321220: JFR: RecordedClass reports incorrect modifiers
  • 9769dfe: 8321214: Parallel: Remove unused SpaceInfo::_min_dense_prefix
  • d23f4f1: 8315559: Delay TempSymbol cleanup to avoid symbol table churn
  • c17b8cf: 8320655: awt screencast robot spin and sync issues with native libpipewire api
  • ed5b8c3: 8225220: When the Tab Policy is checked,the scroll button direction displayed incorrectly.
  • f32ab8c: 8320924: Improve heap dump performance by optimizing archived object checks
  • 93b9235: 8321120: Shenandoah: Remove ShenandoahElasticTLAB flag
  • 9b8eaa2: 8319872: AArch64: [vectorapi] Implementation of unsigned (zero extended) casts
  • b9b8263: 8317307: test/jdk/com/sun/jndi/ldap/LdapPoolTimeoutTest.java fails with ConnectException: Connection timed out: no further information
  • 0d0a657: 5108458: JTable does not properly layout its content
  • ... and 3 more: https://git.openjdk.org/jdk/compare/4dcbd13f99b62de16d6ed13cdf422e6bf9b03a63...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 4, 2023
@openjdk openjdk bot closed this Dec 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 4, 2023
@openjdk
Copy link

openjdk bot commented Dec 4, 2023

@egahlin Pushed as commit d2c529c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
2 participants