8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak

[egahlin]

Could I have a review of a change that fixes intermittent failures in a test.

Testing: 100 * jdk/jfr/event/oldobject/TestListenerLeak.java j

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak (Bug - P4)

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16940/head:pull/16940
$ git checkout pull/16940

Update a local copy of the PR:
$ git checkout pull/16940
$ git pull https://git.openjdk.org/jdk.git pull/16940/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16940

View PR using the GUI difftool:
$ git pr show -t 16940

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16940.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (76044937)

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 9769dfe: 8321214: Parallel: Remove unused SpaceInfo::_min_dense_prefix
• d23f4f1: 8315559: Delay TempSymbol cleanup to avoid symbol table churn
• c17b8cf: 8320655: awt screencast robot spin and sync issues with native libpipewire api
• ed5b8c3: 8225220: When the Tab Policy is checked,the scroll button direction displayed incorrectly.
• f32ab8c: 8320924: Improve heap dump performance by optimizing archived object checks
• 93b9235: 8321120: Shenandoah: Remove ShenandoahElasticTLAB flag
• 9b8eaa2: 8319872: AArch64: [vectorapi] Implementation of unsigned (zero extended) casts
• b9b8263: 8317307: test/jdk/com/sun/jndi/ldap/LdapPoolTimeoutTest.java fails with ConnectException: Connection timed out: no further information
• 0d0a657: 5108458: JTable does not properly layout its content
• 2b00ac0: 8308753: Class-File API transition to Preview
• ... and 1 more: https://git.openjdk.org/jdk/compare/949846986f572dfb82912e7d71e7bfd37a90871e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[egahlin]

/integrate

[openjdk]

Going to push as commit f6be922.
Since your change was applied there have been 14 commits pushed to the master branch:

• a9de5c7: 8315128: jdk/jfr/event/runtime/TestResidentSetSizeEvent.java fails with "The size should be less than or equal to peak"
• d2c529c: 8319072: JFR: Turn off events for JFR.view
• d5f59cf: 8321220: JFR: RecordedClass reports incorrect modifiers
• 9769dfe: 8321214: Parallel: Remove unused SpaceInfo::_min_dense_prefix
• d23f4f1: 8315559: Delay TempSymbol cleanup to avoid symbol table churn
• c17b8cf: 8320655: awt screencast robot spin and sync issues with native libpipewire api
• ed5b8c3: 8225220: When the Tab Policy is checked,the scroll button direction displayed incorrectly.
• f32ab8c: 8320924: Improve heap dump performance by optimizing archived object checks
• 93b9235: 8321120: Shenandoah: Remove ShenandoahElasticTLAB flag
• 9b8eaa2: 8319872: AArch64: [vectorapi] Implementation of unsigned (zero extended) casts
• ... and 4 more: https://git.openjdk.org/jdk/compare/949846986f572dfb82912e7d71e7bfd37a90871e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit f6be922.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.