Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319647: Few java/lang/System/LoggerFinder/modules tests ignore vm flags #16946

Closed
wants to merge 1 commit into from

Conversation

DarraghClarke
Copy link
Contributor

@DarraghClarke DarraghClarke commented Dec 4, 2023

Updated tests to use vm.flagless as they already ignore Vm flags


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8319647: Few java/lang/System/LoggerFinder/modules tests ignore vm flags (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16946/head:pull/16946
$ git checkout pull/16946

Update a local copy of the PR:
$ git checkout pull/16946
$ git pull https://git.openjdk.org/jdk.git pull/16946/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16946

View PR using the GUI difftool:
$ git pr show -t 16946

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16946.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 4, 2023

👋 Welcome back dclarke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 4, 2023
@openjdk
Copy link

openjdk bot commented Dec 4, 2023

@DarraghClarke The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Dec 4, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 4, 2023

Webrevs

@DarraghClarke DarraghClarke changed the title 8319647: Update or mark as vm.flagless tests that ignore external VM flags 8319647: Few java/lang/System/LoggerFinder/modules tests ignore vm flags Dec 5, 2023
@openjdk
Copy link

openjdk bot commented Dec 5, 2023

@DarraghClarke This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319647: Few java/lang/System/LoggerFinder/modules tests ignore vm flags

Reviewed-by: lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 155 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 5, 2023
@DarraghClarke
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 14, 2023

Going to push as commit 62b7c5e.
Since your change was applied there have been 219 commits pushed to the master branch:

  • 69014cd: 8320682: [AArch64] C1 compilation fails with "Field too big for insn"
  • 5a97dbf: 8322034: Parallel: Remove unused methods in PSAdaptiveSizePolicy
  • 2838a91: 8288989: Make tests not depend on the source code
  • d2ba3b1: 8312150: Remove -Xnoagent option
  • d632d74: 8321820: TestLoadNIdeal fails on 32-bit because -XX:+UseCompressedOops is not recognized
  • ddbbd36: 8320279: Link issues in java.xml module-info.java
  • c8ad7b7: 8321974: Crash in ciKlass::is_subtype_of because TypeAryPtr::_klass is not initialized
  • cf94854: 8321565: [REDO] Heap dump does not contain virtual Thread stack references
  • 7ece9e9: 8321400: java/foreign/TestStubAllocFailure.java fails with code cache exhaustion
  • 9320ef9: 8321973: Parallel: Remove unused methods in AdaptiveSizePolicy
  • ... and 209 more: https://git.openjdk.org/jdk/compare/a2c5f1fc914ef5c28d044b75598f895cf6097138...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 14, 2023
@openjdk openjdk bot closed this Dec 14, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 14, 2023
@openjdk
Copy link

openjdk bot commented Dec 14, 2023

@DarraghClarke Pushed as commit 62b7c5e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants