Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321105: Enable UseCryptoPmullForCRC32 for Neoverse V2 #16949

Closed
wants to merge 1 commit into from

Conversation

eastig
Copy link
Member

@eastig eastig commented Dec 4, 2023

UseCryptoPmullForCRC32 enables to use crypto pmull instructions in CRC32 implementation. It is set to true for Neoverse V1. As the performance of the instructions is the same on Neoverse V2, UseCryptoPmullForCRC32 should be set to true for V2.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8321105: Enable UseCryptoPmullForCRC32 for Neoverse V2 (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16949/head:pull/16949
$ git checkout pull/16949

Update a local copy of the PR:
$ git checkout pull/16949
$ git pull https://git.openjdk.org/jdk.git pull/16949/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16949

View PR using the GUI difftool:
$ git pr show -t 16949

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16949.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 4, 2023

👋 Welcome back eastigeevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 4, 2023
@openjdk
Copy link

openjdk bot commented Dec 4, 2023

@eastig The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Dec 4, 2023
@eastig
Copy link
Member Author

eastig commented Dec 4, 2023

@nick-arm, @shipilev, could you please have a look?

@mlbridge
Copy link

mlbridge bot commented Dec 4, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 4, 2023

@eastig This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321105: Enable UseCryptoPmullForCRC32 for Neoverse V2

Reviewed-by: shade, ngasson

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • d2c529c: 8319072: JFR: Turn off events for JFR.view
  • d5f59cf: 8321220: JFR: RecordedClass reports incorrect modifiers
  • 9769dfe: 8321214: Parallel: Remove unused SpaceInfo::_min_dense_prefix

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 4, 2023
@eastig
Copy link
Member Author

eastig commented Dec 5, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Dec 5, 2023

Going to push as commit 5b02188.
Since your change was applied there have been 19 commits pushed to the master branch:

  • 4fbf22b: 8320652: ThreadInfo.isInNative needs to be updated to say what executing native code means
  • 672f373: 8321163: [test] OutputAnalyzer.getExitValue() unnecessarily logs even when process has already completed
  • 30817b7: 8317809: Insertion of free code blobs into code cache can be very slow during class unloading
  • a56286f: 8321269: Require platforms to define DEFAULT_CACHE_LINE_SIZE
  • 1cf7ef5: 8321273: Parallel: Remove unused UpdateOnlyClosure::_space_id
  • 517b178: 8306914: Implement JEP 458: Launch Multi-File Source-Code Programs
  • aec3865: 8320697: RISC-V: Small refactoring for runtime calls
  • 50d1839: 8318809: java/util/concurrent/ConcurrentLinkedQueue/WhiteBox.java shows intermittent failures on linux ppc64le and aarch64
  • 81484d8: 8320687: sun.jvmstat.monitor.MonitoredHost.getMonitoredHost() throws unexpected exceptions when invoked concurrently
  • 30b5d42: 8321069: JvmtiThreadState::state_for_while_locked() returns nullptr for an attached JNI thread with a java.lang.Thread object after JDK-8319935
  • ... and 9 more: https://git.openjdk.org/jdk/compare/d23f4f12adf1ea26b8c340efe2c3854e50b68301...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 5, 2023
@openjdk openjdk bot closed this Dec 5, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 5, 2023
@openjdk
Copy link

openjdk bot commented Dec 5, 2023

@eastig Pushed as commit 5b02188.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@eastig
Copy link
Member Author

eastig commented Dec 5, 2023

@nick-arm @shipilev Thank you for reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
3 participants