8321276: runtime/cds/appcds/dynamicArchive/DynamicSharedSymbols.java failed with "'17 2: jdk/test/lib/apps ' missing from stdout/stderr"

[coleenp]

Please review this trivial change to fix the test to expect that the TempSymbol refcount is 1 more than expected. The symbol is cached in JDK-8315559 Delay TempSymbol cleanup to avoid symbol table churn.

A late change in the review removed draining the queue periodically, which caused this test failure.
Tested locally.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8321276: runtime/cds/appcds/dynamicArchive/DynamicSharedSymbols.java failed with "'17 2: jdk/test/lib/apps ' missing from stdout/stderr" (Bug - P2)

Reviewers

• Daniel D. Daugherty (@dcubed-ojdk - Reviewer)
• @huy164 (no known openjdk.org user name / role)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16954/head:pull/16954
$ git checkout pull/16954

Update a local copy of the PR:
$ git checkout pull/16954
$ git pull https://git.openjdk.org/jdk.git pull/16954/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16954

View PR using the GUI difftool:
$ git pr show -t 16954

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16954.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (45a5b370)
• 00: Full (8cb838fb)

[coleenp]

I'm also running mach5 tier2 on this change with default Oracle platforms.

[dcubed-ojdk]

Thumbs up. This is a trivial fix.

As David likes to say... the proof is in the testing. Thanks for running Mach5 Tier2.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321276: runtime/cds/appcds/dynamicArchive/DynamicSharedSymbols.java failed with "'17 2: jdk/test/lib/apps ' missing from stdout/stderr"

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 65be5e0: 8305931: jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java failed with "Expected chains but found none"
• f6be922: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak
• a9de5c7: 8315128: jdk/jfr/event/runtime/TestResidentSetSizeEvent.java fails with "The size should be less than or equal to peak"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dcubed-ojdk]

Still thumbs up.

[coleenp]

tier2 tests passed beyond failures of this morning. Thanks Dan and thank you @huy164 for the reviews.
/integrate

[openjdk]

Going to push as commit 316b783.
Since your change was applied there have been 3 commits pushed to the master branch:

• 65be5e0: 8305931: jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java failed with "Expected chains but found none"
• f6be922: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak
• a9de5c7: 8315128: jdk/jfr/event/runtime/TestResidentSetSizeEvent.java fails with "The size should be less than or equal to peak"

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit 316b783.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.