8317831: compiler/codecache/CheckLargePages.java fails on OL 8.8 with unexpected memory string #16962

yftsai · 2023-12-05T01:08:10Z

Test CheckLargePages was broken by the previous changes:

JDK-8310233 changes the pagesize logs from

Usable page sizes: 4k, 1G

to

Large page support enabled. Usable page sizes: 4k, 1G. Default large page size: 1G.

JDK-8261894 removes UseHugeTLBFS. It was also removed from os::can_execute_large_page_memory, and CodeCache::page_size cannot use huge pages anymore.

This change includes:

The regular expression in CheckLargePages is updated to capture only the page sizes.
The static huge page will be fixed by JDK-8319795.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8317831: compiler/codecache/CheckLargePages.java fails on OL 8.8 with unexpected memory string (Bug - P4)

Reviewers

Evgeny Astigeevich (@eastig - Committer)
David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16962/head:pull/16962
$ git checkout pull/16962

Update a local copy of the PR:
$ git checkout pull/16962
$ git pull https://git.openjdk.org/jdk.git pull/16962/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16962

View PR using the GUI difftool:
$ git pr show -t 16962

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16962.diff

Webrev

Link to Webrev Comment

… unexpected memory string Test CheckLargePages was broken by the previous changes: JDK-8261894 removes UseHugeTLBFS and prevents pre-allocates large pages up-front. (UseHugeTLBFS was removed from os::can_execute_large_page_memory.) JDK-8310233 changes the pagesize logs from ``` Usable page sizes: 4k, 1G ``` to ``` Large page support enabled. Usable page sizes: 4k, 1G. Default large page size: 1G. ``` This change adds UseTransparentHugePages to the test and pre-allocates large pages for code cache. ReservedCodeCacheSize and InitialCodeCacheSize are reduced to smaller than 2M * 8 to trigger reducing the page sizes. The regular expression is updated to capture only page sizes.

… unexpected memory string Test CheckLargePages was broken by the previous changes: JDK-8261894 removes UseHugeTLBFS. It is also removed from `os::can_execute_large_page_memory`, and `CodeCache::page_size` cannot longer use hughe pages. JDK-8310233 changes the pagesize logs from ``` Usable page sizes: 4k, 1G ``` to ``` Large page support enabled. Usable page sizes: 4k, 1G. Default large page size: 1G. ``` This change adds UseLargePages back to where UseHugeTLBFS is in `os::can_execute_large_page_memory`. The regular expression is updated to capture only page sizes.

bridgekeeper · 2023-12-05T01:09:42Z

👋 Welcome back yftsai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-12-05T01:11:41Z

@yftsai The following label will be automatically applied to this pull request:

hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2023-12-05T01:16:04Z

Webrevs

01: Full - Incremental (54c763ee)
00: Full (580a2f93)

eastig · 2023-12-05T13:48:36Z

src/hotspot/os/linux/os_linux.cpp

@@ -4004,7 +4004,7 @@ bool os::can_commit_large_page_memory() {
 }

 bool os::can_execute_large_page_memory() {
-  return UseTransparentHugePages;
+  return UseLargePages;


Could you please exclude this change from the PR? The function will be removed by my PR.

In test/hotspot/jtreg/ProblemList.txt could you please change

compiler/codecache/CheckLargePages.java 8317831 linux-x64

to

compiler/codecache/CheckLargePages.java 8319795 linux-x64

eastig · 2023-12-05T14:57:37Z

I tested my PR #16582 with the fixed test. The test passed as expected.

eastig · 2023-12-05T15:01:52Z

Hi @tstuefe,
Could you please have a look? I'd like this to go before my #16582 because I'll be adding new test cases to CheckLargePages.java.
I'll update test/hotspot/jtreg/ProblemList.txt in my #16582.

eastig

lgtm

dholmes-ora

I'm going to approve this test fix as the change to the regex itself seems reasonable, even though because the test remains excluded by JDK-8319795 we won't actually be testing it. If any issues arise when the test is removed from the ProblemList it is expected that JDK-8319795 will deal with that.

Thanks

openjdk · 2023-12-06T01:13:10Z

@yftsai This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317831: compiler/codecache/CheckLargePages.java fails on OL 8.8 with unexpected memory string

Reviewed-by: eastigeevich, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 382 new commits pushed to the master branch:

3cd65ce: 8321325: Remove unused Java_java_awt_MenuComponent_initIDs function
905137d: 8321219: runtime/jni/FastGetField: assert(is_interpreted_frame()) failed: interpreted frame expected
430564c: 8308715: Create a mechanism for Implicitly Declared Class javadoc
c8fa758: 8320860: add-opens/add-exports require '=' in JAVA_TOOL_OPTIONS
9e57010: 8315149: Add hsperf counters for CPU time of internal GC threads
b0d1450: 8321053: Use ByteArrayInputStream.buf directly when parameter of transferTo() is trusted
acaf2c8: 8318590: JButton ignores margin when painting HTML text
d3df3eb: 8294699: Launcher causes lingering busy cursor
fddc02e: 8321225: [JVMCI] HotSpotResolvedObjectTypeImpl.isLeafClass shouldn't create strong references
640d7f3: 8314327: Issues with JShell when using "local" execution engine
... and 372 more: https://git.openjdk.org/jdk/compare/806529aa77e1977360cd3885b595797bea98e920...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@eastig, @dholmes-ora) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

yftsai · 2023-12-06T01:47:16Z

/integrate

openjdk · 2023-12-06T01:49:02Z

@yftsai
Your change (at version 54c763e) is now ready to be sponsored by a Committer.

dholmes-ora · 2023-12-06T02:33:57Z

/sponsor

openjdk · 2023-12-06T02:34:28Z

Going to push as commit 86b27b7.
Since your change was applied there have been 382 commits pushed to the master branch:

3cd65ce: 8321325: Remove unused Java_java_awt_MenuComponent_initIDs function
905137d: 8321219: runtime/jni/FastGetField: assert(is_interpreted_frame()) failed: interpreted frame expected
430564c: 8308715: Create a mechanism for Implicitly Declared Class javadoc
c8fa758: 8320860: add-opens/add-exports require '=' in JAVA_TOOL_OPTIONS
9e57010: 8315149: Add hsperf counters for CPU time of internal GC threads
b0d1450: 8321053: Use ByteArrayInputStream.buf directly when parameter of transferTo() is trusted
acaf2c8: 8318590: JButton ignores margin when painting HTML text
d3df3eb: 8294699: Launcher causes lingering busy cursor
fddc02e: 8321225: [JVMCI] HotSpotResolvedObjectTypeImpl.isLeafClass shouldn't create strong references
640d7f3: 8314327: Issues with JShell when using "local" execution engine
... and 372 more: https://git.openjdk.org/jdk/compare/806529aa77e1977360cd3885b595797bea98e920...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-12-06T02:34:38Z

@dholmes-ora @yftsai Pushed as commit 86b27b7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Yi-Fan Tsai added 3 commits November 8, 2023 18:59

Reserve ProblemList.txt

580a2f9

openjdk bot added the rfr Pull request is ready for review label Dec 5, 2023

openjdk bot added the hotspot hotspot-dev@openjdk.org label Dec 5, 2023

eastig suggested changes Dec 5, 2023

View reviewed changes

Reserve only regular expression

54c763e

eastig approved these changes Dec 5, 2023

View reviewed changes

dholmes-ora approved these changes Dec 6, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Dec 6, 2023

openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 6, 2023

openjdk bot added the integrated Pull request has been integrated label Dec 6, 2023

openjdk bot closed this Dec 6, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 6, 2023

yftsai deleted the JDK-8317831 branch December 6, 2023 19:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8317831: compiler/codecache/CheckLargePages.java fails on OL 8.8 with unexpected memory string #16962

8317831: compiler/codecache/CheckLargePages.java fails on OL 8.8 with unexpected memory string #16962

yftsai commented Dec 5, 2023 •

edited by openjdk bot

Loading

bridgekeeper bot commented Dec 5, 2023

openjdk bot commented Dec 5, 2023

mlbridge bot commented Dec 5, 2023 •

edited

Loading

eastig Dec 5, 2023

eastig commented Dec 5, 2023

eastig commented Dec 5, 2023

eastig left a comment

dholmes-ora left a comment

openjdk bot commented Dec 6, 2023

yftsai commented Dec 6, 2023

openjdk bot commented Dec 6, 2023

dholmes-ora commented Dec 6, 2023

openjdk bot commented Dec 6, 2023

openjdk bot commented Dec 6, 2023

8317831: compiler/codecache/CheckLargePages.java fails on OL 8.8 with unexpected memory string #16962

8317831: compiler/codecache/CheckLargePages.java fails on OL 8.8 with unexpected memory string #16962

Conversation

yftsai commented Dec 5, 2023 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Dec 5, 2023

openjdk bot commented Dec 5, 2023

mlbridge bot commented Dec 5, 2023 • edited Loading

Webrevs

eastig Dec 5, 2023

Choose a reason for hiding this comment

eastig commented Dec 5, 2023

eastig commented Dec 5, 2023

eastig left a comment

Choose a reason for hiding this comment

dholmes-ora left a comment

Choose a reason for hiding this comment

openjdk bot commented Dec 6, 2023

yftsai commented Dec 6, 2023

openjdk bot commented Dec 6, 2023

dholmes-ora commented Dec 6, 2023

openjdk bot commented Dec 6, 2023

openjdk bot commented Dec 6, 2023

yftsai commented Dec 5, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Dec 5, 2023 •

edited

Loading