Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321216: SerialGC attempts to access the card table beyond the end of the heap during card table scan #16968

Closed

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Dec 5, 2023

Hi all,

please review this fix to CardTableRS::find_first_clean_card where when iterating through the object at the very end of the heap Serial GC accesses the card table beyond the allocated memory, which fails with an assert.

The fix is to allow retrieving addresses for cards beyond the card table using a special addr_for_raw method.

In discussions with @albertnetymk , the initial version to add a check whether the current scan cursor is already at or beyond the end of the area to find clean cards for using an extra, somewhat superfluous parameter has been rejected as a bit confusing (the first commit).

Testing: failing test case, gha

Thanks,
Thomas


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8321216: SerialGC attempts to access the card table beyond the end of the heap during card table scan (Bug - P1)

Reviewers

Contributors

  • Albert Mingkun Yang <ayang@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16968/head:pull/16968
$ git checkout pull/16968

Update a local copy of the PR:
$ git checkout pull/16968
$ git pull https://git.openjdk.org/jdk.git pull/16968/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16968

View PR using the GUI difftool:
$ git pr show -t 16968

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16968.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 5, 2023

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8321216 8321216: SerialGC attempts to access the card table beyond the end of the heap during card table scan Dec 5, 2023
@openjdk
Copy link

openjdk bot commented Dec 5, 2023

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Dec 5, 2023
@tschatzl tschatzl force-pushed the submit/8321216-scan-beyond-heap branch from 03f1561 to 4b7fbac Compare December 5, 2023 09:52
@tschatzl tschatzl force-pushed the submit/8321216-scan-beyond-heap branch from 4b7fbac to 68dcf92 Compare December 5, 2023 09:54
@tschatzl
Copy link
Contributor Author

tschatzl commented Dec 5, 2023

/contributor add @albertnetymk

@openjdk
Copy link

openjdk bot commented Dec 5, 2023

@tschatzl
Contributor Albert Mingkun Yang <ayang@openjdk.org> successfully added.

@tschatzl tschatzl marked this pull request as ready for review December 5, 2023 11:20
@openjdk
Copy link

openjdk bot commented Dec 5, 2023

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321216: SerialGC attempts to access the card table beyond the end of the heap during card table scan

Co-authored-by: Albert Mingkun Yang <ayang@openjdk.org>
Reviewed-by: ayang, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 4fbf22b: 8320652: ThreadInfo.isInNative needs to be updated to say what executing native code means
  • 672f373: 8321163: [test] OutputAnalyzer.getExitValue() unnecessarily logs even when process has already completed
  • 30817b7: 8317809: Insertion of free code blobs into code cache can be very slow during class unloading
  • a56286f: 8321269: Require platforms to define DEFAULT_CACHE_LINE_SIZE

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 5, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 5, 2023

Webrevs

@tschatzl
Copy link
Contributor Author

tschatzl commented Dec 5, 2023

Thanks @albertnetymk @walulyai for your reviews.
I'll integrate early because it makes a mess of the CI pipeline, and the change seems obvious enough.

/integrate

@openjdk
Copy link

openjdk bot commented Dec 5, 2023

Going to push as commit 800f347.
Since your change was applied there have been 6 commits pushed to the master branch:

  • a1fe16b: 8321300: Cleanup TestHFA
  • 5b02188: 8321105: Enable UseCryptoPmullForCRC32 for Neoverse V2
  • 4fbf22b: 8320652: ThreadInfo.isInNative needs to be updated to say what executing native code means
  • 672f373: 8321163: [test] OutputAnalyzer.getExitValue() unnecessarily logs even when process has already completed
  • 30817b7: 8317809: Insertion of free code blobs into code cache can be very slow during class unloading
  • a56286f: 8321269: Require platforms to define DEFAULT_CACHE_LINE_SIZE

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 5, 2023
@openjdk openjdk bot closed this Dec 5, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 5, 2023
@openjdk
Copy link

openjdk bot commented Dec 5, 2023

@tschatzl Pushed as commit 800f347.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8321216-scan-beyond-heap branch January 16, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants