New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8257905: Make fixpath.sh more liberal in accepting paths embedded in arguments #1698
Conversation
👋 Welcome back ihse! A progress list of the required criteria for merging this PR into |
Webrevs
|
@magicus This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@magicus Since your change was applied there have been 3 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 264feb3. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
When calling a Windows tool that needs an argument on the form
-option/a:/home/ihse/myjdk/...
, fixpath gets confused and thinks/a:/home/ihse/myjdk
is a unix path, notices that it does not exists, and stops trying to convert the path.Instead it needs to recheck for paths after a separator such as
:
or=
.Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1698/head:pull/1698
$ git checkout pull/1698