8320139: [JVMCI] VmObjectAlloc is not generated by intrinsics methods which allocate objects

[rmosaner]

This PR exports a pointer to JvmtiExport::_should_notify_object_alloc via JVMCI to enable intrinsification of unsafe allocations in accordance to C2.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8320139: [JVMCI] VmObjectAlloc is not generated by intrinsics methods which allocate objects (Bug - P4)

Reviewers

• Tom Rodriguez (@tkrodriguez - Reviewer)
• Doug Simon (@dougxc - Reviewer) ⚠️ Review applies to 0b430d8b

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16980/head:pull/16980
$ git checkout pull/16980

Update a local copy of the PR:
$ git checkout pull/16980
$ git pull https://git.openjdk.org/jdk.git pull/16980/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16980

View PR using the GUI difftool:
$ git pr show -t 16980

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16980.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

Hi @rmosaner, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user rmosaner" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

@rmosaner The following labels will be automatically applied to this pull request:

• graal
• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[openjdk]

@rmosaner Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[mlbridge]

Webrevs

• 01: Full - Incremental (35b2fd9c)
• 00: Full (0b430d8b)

[openjdk]

@rmosaner This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320139: [JVMCI] VmObjectAlloc is not generated by intrinsics methods which allocate objects

Reviewed-by: never, dnsimon

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 166 new commits pushed to the master branch:

• 3b908c4: 8319795: Static huge pages are not used for CodeCache
• 1802601: 8293623: Simplify G1ConcurrentRefineThreadControl
• 6de23bf: 8322418: Problem list gc/TestAllocHumongousFragment.java subtests for 8298781
• aff659a: 8322538: remove fatal from JVM_VirtualThread functions for !INCLUDE_JVMTI
• 05745e3: 8319548: Unexpected internal name for Filler array klass causes error in VisualVM
• e8768ae: 8321972: test runtime/Unsafe/InternalErrorTest.java timeout on linux-riscv64 platform
• f6fe39f: 8322078: ZipSourceCache.testKeySourceMapping() test fails with The process cannot access the file because it is being used by another process
• e204242: 8321017: Record in JFR that IEEE rounding mode was corrupted by loading a library
• 2d60955: 8322141: SequenceInputStream.transferTo should not return as soon as Long.MAX_VALUE bytes have been transferred
• e0bad51: 8322543: Parallel: Remove unused _major_pause_old_slope_counter
• ... and 156 more: https://git.openjdk.org/jdk/compare/7fbfb3b74a283261027e6c293e1a5dbc354cf0af...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tkrodriguez, @dougxc) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[rmosaner]

/integrate

[openjdk]

@rmosaner
Your change (at version 0b430d8) is now ready to be sponsored by a Committer.

[rmosaner]

/integrate

[openjdk]

@rmosaner
Your change (at version 35b2fd9) is now ready to be sponsored by a Committer.

[tkrodriguez]

Looks good.

/sponsor

[openjdk]

Going to push as commit 84c2379.
Since your change was applied there have been 166 commits pushed to the master branch:

• 3b908c4: 8319795: Static huge pages are not used for CodeCache
• 1802601: 8293623: Simplify G1ConcurrentRefineThreadControl
• 6de23bf: 8322418: Problem list gc/TestAllocHumongousFragment.java subtests for 8298781
• aff659a: 8322538: remove fatal from JVM_VirtualThread functions for !INCLUDE_JVMTI
• 05745e3: 8319548: Unexpected internal name for Filler array klass causes error in VisualVM
• e8768ae: 8321972: test runtime/Unsafe/InternalErrorTest.java timeout on linux-riscv64 platform
• f6fe39f: 8322078: ZipSourceCache.testKeySourceMapping() test fails with The process cannot access the file because it is being used by another process
• e204242: 8321017: Record in JFR that IEEE rounding mode was corrupted by loading a library
• 2d60955: 8322141: SequenceInputStream.transferTo should not return as soon as Long.MAX_VALUE bytes have been transferred
• e0bad51: 8322543: Parallel: Remove unused _major_pause_old_slope_counter
• ... and 156 more: https://git.openjdk.org/jdk/compare/7fbfb3b74a283261027e6c293e1a5dbc354cf0af...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tkrodriguez @rmosaner Pushed as commit 84c2379.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[DamonFool]

Hi, the build failure was observed after this patch.
Please take a look: #17182 .
Thanks.