8315827: Kitchensink.java and RenaissanceStressTest.java time out with jvmti module errors

[mgronlun]

Greetings,

A deadlock interaction pattern has surfaced where the JFR sampler thread has suspended a thread, reportedly in state thread_in_java. That thread is currently running barrier code and is holding a semaphore as part of logging inside of LogFileOutput::write( ).

When the JFR thread sampler attempts to read the thread status from the thread object, it triggers the same barrier code, eventually waiting for the semaphore inside LogFileOutput::write( ). Since the owner is suspended, a deadlock ensues.

To avoid triggering barriers as part of the sampler code, we can avoid reading the thread status from the thread object as part of sampling. This is especially so because we know what the thread state is at this point, especially for _thread_in_java but also for _thread_in_native. It is most likely JavaThreadStatus::RUNNABLE (5). Write it as a constant.

Testing: jdk_jfr

Thanks
Markus

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8315827: Kitchensink.java and RenaissanceStressTest.java time out with jvmti module errors (Bug - P2)

Reviewers

• Erik Gahlin (@egahlin - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16982/head:pull/16982
$ git checkout pull/16982

Update a local copy of the PR:
$ git checkout pull/16982
$ git pull https://git.openjdk.org/jdk.git pull/16982/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16982

View PR using the GUI difftool:
$ git pr show -t 16982

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16982.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mgronlun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mgronlun The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (727488df)

[openjdk]

@mgronlun This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315827: Kitchensink.java and RenaissanceStressTest.java time out with jvmti module errors

Reviewed-by: egahlin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

• a9cb120: 8320948: NPE due to unreported compiler error
• 4ef24e2: 8319938: TestFileChooserSingleDirectorySelection.java fails with "getSelectedFiles returned empty array"
• cc25d8b: 8319662: ForkJoinPool trims worker threads too slowly
• 90e433d: 8320144: Compilation crashes when a custom annotation with invalid default value is used
• 50f3124: 8320892: AArch64: Restore FPU control state after JNI
• 0217b5a: 8321248: ClassFile API ClassModel::verify is inconsistent with the rest of the API
• 7fbfb3b: 8321369: Unproblemlist gc/cslocker/TestCSLocker.java
• 2678e4c: 8319111: Mismatched MemorySegment heap access is not consistently intrinsified
• a0920aa: 8321159: SymbolLookup.libraryLookup(Path, Arena) Assumes default Filesystem
• 9d77677: 8321124: java/util/stream/GatherersTest.java times out
• ... and 19 more: https://git.openjdk.org/jdk/compare/027b5dbb6a299e49d3dcbe67d529d6edc67f16d9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mgronlun]

/integrate

[openjdk]

Going to push as commit 75a7c19.
Since your change was applied there have been 39 commits pushed to the master branch:

• 91ffdfb: 8320365: IPPPrintService.getAttributes() causes blanket re-initialisation
• 50baaf4: 8321013: Parallel: Refactor ObjectStartArray
• afb8964: 8320443: [macos] Test java/awt/print/PrinterJob/PrinterDevice.java fails on macOS
• 82796bd: 8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters
• 781775d: 8321484: Make TestImplicitlyDeclaredClasses release independent
• b02fc86: 8321122: Shenandoah: Remove ShenandoahLoopOptsAfterExpansion flag
• 2830dd2: 8321410: Shenandoah: Remove ShenandoahSuspendibleWorkers flag
• f482260: 8319969: os::large_page_init() turns off THPs for ZGC
• 3edc24a: 8321073: Defer policy of disabling annotation processing by default
• dc9c77b: 8318756: Create better internal buffer for AEADs
• ... and 29 more: https://git.openjdk.org/jdk/compare/027b5dbb6a299e49d3dcbe67d529d6edc67f16d9...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mgronlun Pushed as commit 75a7c19.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.