8321406: Null IDs should be resolved as before catalogs are added

[JoeWang-Java]

Improve null handling. When both the public and system IDs are null, this change lets the resolution process continue as usual, before the catalogs were added. This is consistent with the process on the other part of the program where a CatalogResolver is used only when the IDs are not null.

Test: existing XML tests passed.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8321406: Null IDs should be resolved as before catalogs are added (Enhancement - P4)

Reviewers

• Naoto Sato (@naotoj - Reviewer)
• Iris Clark (@irisclark - Reviewer)
• Lance Andersen (@LanceAndersen - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16983/head:pull/16983
$ git checkout pull/16983

Update a local copy of the PR:
$ git checkout pull/16983
$ git pull https://git.openjdk.org/jdk.git pull/16983/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16983

View PR using the GUI difftool:
$ git pr show -t 16983

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16983.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back joehw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@JoeWang-Java The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (9c10a12f)

[openjdk]

@JoeWang-Java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321406: Null IDs should be resolved as before catalogs are added

Reviewed-by: naoto, iris, lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 108 new commits pushed to the master branch:

• 430564c: 8308715: Create a mechanism for Implicitly Declared Class javadoc
• c8fa758: 8320860: add-opens/add-exports require '=' in JAVA_TOOL_OPTIONS
• 9e57010: 8315149: Add hsperf counters for CPU time of internal GC threads
• b0d1450: 8321053: Use ByteArrayInputStream.buf directly when parameter of transferTo() is trusted
• acaf2c8: 8318590: JButton ignores margin when painting HTML text
• d3df3eb: 8294699: Launcher causes lingering busy cursor
• fddc02e: 8321225: [JVMCI] HotSpotResolvedObjectTypeImpl.isLeafClass shouldn't create strong references
• 640d7f3: 8314327: Issues with JShell when using "local" execution engine
• db5613a: 8317288: [macos] java/awt/Window/Grab/GrabTest.java: Press on the outside area didn't cause ungrab
• b1cb374: 8320349: Simplify FileChooserSymLinkTest.java by using single-window testUI
• ... and 98 more: https://git.openjdk.org/jdk/compare/da7bcfcf6e45486a0427e0ceaba74d52acbd722f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[JoeWang-Java]

/integrate

[openjdk]

Going to push as commit 78d0958.
Since your change was applied there have been 112 commits pushed to the master branch:

• aaaae3e: 8321207: javac is not accepting correct code
• 86b27b7: 8317831: compiler/codecache/CheckLargePages.java fails on OL 8.8 with unexpected memory string
• 3cd65ce: 8321325: Remove unused Java_java_awt_MenuComponent_initIDs function
• 905137d: 8321219: runtime/jni/FastGetField: assert(is_interpreted_frame()) failed: interpreted frame expected
• 430564c: 8308715: Create a mechanism for Implicitly Declared Class javadoc
• c8fa758: 8320860: add-opens/add-exports require '=' in JAVA_TOOL_OPTIONS
• 9e57010: 8315149: Add hsperf counters for CPU time of internal GC threads
• b0d1450: 8321053: Use ByteArrayInputStream.buf directly when parameter of transferTo() is trusted
• acaf2c8: 8318590: JButton ignores margin when painting HTML text
• d3df3eb: 8294699: Launcher causes lingering busy cursor
• ... and 102 more: https://git.openjdk.org/jdk/compare/da7bcfcf6e45486a0427e0ceaba74d52acbd722f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@JoeWang-Java Pushed as commit 78d0958.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.