Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321410: Shenandoah: Remove ShenandoahSuspendibleWorkers flag #16984

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Dec 5, 2023

We have flipped ShenandoahSuspendibleWorkers to true in JDK-8305403, and backported it back to 17.0.8. We seem to be in consensus that turning this flag off would likely to cause correctness issues:
#13309 (comment)

So we might as well remove this flag altogether.

Additional testing:

  • hotspot_gc_shenandoah

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8321410: Shenandoah: Remove ShenandoahSuspendibleWorkers flag (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16984/head:pull/16984
$ git checkout pull/16984

Update a local copy of the PR:
$ git checkout pull/16984
$ git pull https://git.openjdk.org/jdk.git pull/16984/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16984

View PR using the GUI difftool:
$ git pr show -t 16984

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16984.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 5, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 5, 2023
@openjdk
Copy link

openjdk bot commented Dec 5, 2023

@shipilev The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Dec 5, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 5, 2023

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Dec 6, 2023

Looking for blessing from @rkennke as well.

Copy link
Contributor

@rkennke rkennke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is a correctness issue, let's get rid of the flag.

I believe that you could also replace ShenandoahSuspendibleThreadSet* with just regular SuspendibleThreadSet*.

@openjdk
Copy link

openjdk bot commented Dec 6, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321410: Shenandoah: Remove ShenandoahSuspendibleWorkers flag

Reviewed-by: rkennke

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • f482260: 8319969: os::large_page_init() turns off THPs for ZGC
  • 3edc24a: 8321073: Defer policy of disabling annotation processing by default
  • dc9c77b: 8318756: Create better internal buffer for AEADs
  • a9cb120: 8320948: NPE due to unreported compiler error
  • 4ef24e2: 8319938: TestFileChooserSingleDirectorySelection.java fails with "getSelectedFiles returned empty array"
  • cc25d8b: 8319662: ForkJoinPool trims worker threads too slowly
  • 90e433d: 8320144: Compilation crashes when a custom annotation with invalid default value is used
  • 50f3124: 8320892: AArch64: Restore FPU control state after JNI
  • 0217b5a: 8321248: ClassFile API ClassModel::verify is inconsistent with the rest of the API
  • 7fbfb3b: 8321369: Unproblemlist gc/cslocker/TestCSLocker.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 6, 2023
@shipilev
Copy link
Member Author

shipilev commented Dec 6, 2023

Thanks!

/integrate

@openjdk
Copy link

openjdk bot commented Dec 6, 2023

Going to push as commit 2830dd2.
Since your change was applied there have been 10 commits pushed to the master branch:

  • f482260: 8319969: os::large_page_init() turns off THPs for ZGC
  • 3edc24a: 8321073: Defer policy of disabling annotation processing by default
  • dc9c77b: 8318756: Create better internal buffer for AEADs
  • a9cb120: 8320948: NPE due to unreported compiler error
  • 4ef24e2: 8319938: TestFileChooserSingleDirectorySelection.java fails with "getSelectedFiles returned empty array"
  • cc25d8b: 8319662: ForkJoinPool trims worker threads too slowly
  • 90e433d: 8320144: Compilation crashes when a custom annotation with invalid default value is used
  • 50f3124: 8320892: AArch64: Restore FPU control state after JNI
  • 0217b5a: 8321248: ClassFile API ClassModel::verify is inconsistent with the rest of the API
  • 7fbfb3b: 8321369: Unproblemlist gc/cslocker/TestCSLocker.java

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 6, 2023
@openjdk openjdk bot closed this Dec 6, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 6, 2023
@openjdk
Copy link

openjdk bot commented Dec 6, 2023

@shipilev Pushed as commit 2830dd2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8321410-shenandoah-suspendible-workers branch January 9, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org
2 participants