8321470: ThreadLocal.nextHashCode can be static final

[bokken]

The static AtomicInteger used for the nextHashCode should be final.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8321470: ThreadLocal.nextHashCode can be static final (Enhancement - P4)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16987/head:pull/16987
$ git checkout pull/16987

Update a local copy of the PR:
$ git checkout pull/16987
$ git pull https://git.openjdk.org/jdk.git pull/16987/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16987

View PR using the GUI difftool:
$ git pr show -t 16987

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16987.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

Hi @bokken, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user bokken" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[bokken]

/covered

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[openjdk]

@bokken The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[shipilev]

Submitted: https://bugs.openjdk.org/browse/JDK-8321470

Please change this PR title to "8321470: ThreadLocal.nextHashCode can be static final", and bots would do the rest.

[mlbridge]

Webrevs

• 01: Full - Incremental (d05272a3)
• 00: Full (9e276138)

[shipilev]

Looks okay to me!

Since this is new contribution, I would like someone else to take a look.
/reviewers 2

[openjdk]

⚠️ @bokken the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout threadlocal_final
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

[openjdk]

@bokken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321470: ThreadLocal.nextHashCode can be static final

Reviewed-by: shade, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

• 42bb852: 8321467: MemorySegment.setString(long, String, Charset) throws IAE(Misaligned access)
• c087e91: 8321505: JFR: Update views
• ead4fb1: 8321519: Typo in exception message
• b5933b1: 8320805: JFR: Create view for deprecated methods
• 29d7a22: 8321270: Virtual Thread.yield consumes parking permit
• 0b0fa47: 8319925: CSS.BackgroundImage incorrectly uses double-checked locking
• 0048f1d: 8263256: Test java/net/Inet6Address/serialize/Inet6AddressSerializationTest.java fails due to dynamic reconfigurations of network interface during test
• 49fff01: 8211238: @deprecated JFR event
• 656b446: 8320969: Shenandoah: Enforce stable number of GC workers
• 9a87e52: 8320538: Obsolete CSS styles in collection framework doc-file
• ... and 19 more: https://git.openjdk.org/jdk/compare/7fbfb3b74a283261027e6c293e1a5dbc354cf0af...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev, @jaikiran) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@shipilev
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[jaikiran]

The change looks fine to me.

[shipilev]

@bokken, you are good to /integrate.

[bokken]

/integrate

[openjdk]

@bokken
Your change (at version d05272a) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit c42535f.
Since your change was applied there have been 29 commits pushed to the master branch:

• 42bb852: 8321467: MemorySegment.setString(long, String, Charset) throws IAE(Misaligned access)
• c087e91: 8321505: JFR: Update views
• ead4fb1: 8321519: Typo in exception message
• b5933b1: 8320805: JFR: Create view for deprecated methods
• 29d7a22: 8321270: Virtual Thread.yield consumes parking permit
• 0b0fa47: 8319925: CSS.BackgroundImage incorrectly uses double-checked locking
• 0048f1d: 8263256: Test java/net/Inet6Address/serialize/Inet6AddressSerializationTest.java fails due to dynamic reconfigurations of network interface during test
• 49fff01: 8211238: @deprecated JFR event
• 656b446: 8320969: Shenandoah: Enforce stable number of GC workers
• 9a87e52: 8320538: Obsolete CSS styles in collection framework doc-file
• ... and 19 more: https://git.openjdk.org/jdk/compare/7fbfb3b74a283261027e6c293e1a5dbc354cf0af...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @bokken Pushed as commit c42535f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.