Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8320538: Obsolete CSS styles in collection framework doc-file #16997

Closed
wants to merge 1 commit into from

Conversation

hns
Copy link
Member

@hns hns commented Dec 6, 2023

Please review a simple change to remove a stray inline CSS element from the Collection Framework index doc file. The only thing the a {font-weight: bold;} rule did was to make all links in the header and footer bold as can be seen here; the three content links to the other doc files are still displayed in bold font because they are contained in <b> tags. The other CSS rules had no effect in the page.

Screenshot of the fixed page:
coll-framework-index

I also added the <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> meta tag which is present in all other pages (both doc-files and generated by JavaDoc).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8320538: Obsolete CSS styles in collection framework doc-file (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16997/head:pull/16997
$ git checkout pull/16997

Update a local copy of the PR:
$ git checkout pull/16997
$ git pull https://git.openjdk.org/jdk.git pull/16997/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16997

View PR using the GUI difftool:
$ git pr show -t 16997

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16997.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 6, 2023

👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 6, 2023
@openjdk
Copy link

openjdk bot commented Dec 6, 2023

@hns The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Dec 6, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 6, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 7, 2023

@hns This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320538: Obsolete CSS styles in collection framework doc-file

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • 632a3c5: 8305825: getBounds API returns wrong value resulting in multiple Regression Test Failures on Ubuntu 23.04
  • 75a7c19: 8315827: Kitchensink.java and RenaissanceStressTest.java time out with jvmti module errors
  • 91ffdfb: 8320365: IPPPrintService.getAttributes() causes blanket re-initialisation
  • 50baaf4: 8321013: Parallel: Refactor ObjectStartArray
  • afb8964: 8320443: [macos] Test java/awt/print/PrinterJob/PrinterDevice.java fails on macOS
  • 82796bd: 8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters
  • 781775d: 8321484: Make TestImplicitlyDeclaredClasses release independent
  • b02fc86: 8321122: Shenandoah: Remove ShenandoahLoopOptsAfterExpansion flag
  • 2830dd2: 8321410: Shenandoah: Remove ShenandoahSuspendibleWorkers flag
  • f482260: 8319969: os::large_page_init() turns off THPs for ZGC
  • ... and 5 more: https://git.openjdk.org/jdk/compare/90e433d72e73abf3252969f535451b56ecacc952...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 7, 2023
@hns
Copy link
Member Author

hns commented Dec 7, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Dec 7, 2023

Going to push as commit 9a87e52.
Since your change was applied there have been 16 commits pushed to the master branch:

  • 03c4595: 8321164: javac with annotation processor throws AssertionError: Filling jrt:/... during JarFileObject[/...]
  • 632a3c5: 8305825: getBounds API returns wrong value resulting in multiple Regression Test Failures on Ubuntu 23.04
  • 75a7c19: 8315827: Kitchensink.java and RenaissanceStressTest.java time out with jvmti module errors
  • 91ffdfb: 8320365: IPPPrintService.getAttributes() causes blanket re-initialisation
  • 50baaf4: 8321013: Parallel: Refactor ObjectStartArray
  • afb8964: 8320443: [macos] Test java/awt/print/PrinterJob/PrinterDevice.java fails on macOS
  • 82796bd: 8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters
  • 781775d: 8321484: Make TestImplicitlyDeclaredClasses release independent
  • b02fc86: 8321122: Shenandoah: Remove ShenandoahLoopOptsAfterExpansion flag
  • 2830dd2: 8321410: Shenandoah: Remove ShenandoahSuspendibleWorkers flag
  • ... and 6 more: https://git.openjdk.org/jdk/compare/90e433d72e73abf3252969f535451b56ecacc952...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 7, 2023
@openjdk openjdk bot closed this Dec 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 7, 2023
@openjdk
Copy link

openjdk bot commented Dec 7, 2023

@hns Pushed as commit 9a87e52.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants