Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8263256: Test java/net/Inet6Address/serialize/Inet6AddressSerializationTest.java fails due to dynamic reconfigurations of network interface during test #16998

Closed
wants to merge 3 commits into from

Conversation

msheppar
Copy link

@msheppar msheppar commented Dec 6, 2023

Test java/net/Inet6Address/serialize/Inet6AddressSerializationTest.java fails fails due to dynamic reconfigurations of network interface during test - this fix uses the utility method NetworkConfiguration::isSameInterface to replace NetworkInterface::equals method call. Additionally, for macosx the awdl and llw interfaces are excluded from the test

Please oblige and review this change to address issue https://bugs.openjdk.org/browse/JDK-8263256


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8263256: Test java/net/Inet6Address/serialize/Inet6AddressSerializationTest.java fails due to dynamic reconfigurations of network interface during test (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16998/head:pull/16998
$ git checkout pull/16998

Update a local copy of the PR:
$ git checkout pull/16998
$ git pull https://git.openjdk.org/jdk.git pull/16998/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16998

View PR using the GUI difftool:
$ git pr show -t 16998

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16998.diff

Webrev

Link to Webrev Comment

…zationTest.java fails due to dynamic reconfigurations of network interface during test - a fix which uses the utility method NetworkConfiguration::isSameInterface to replace NetworkInterface::equals method call. Additionally, for macosx the awdl and llw interfaces are excluded from the test
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 6, 2023

👋 Welcome back msheppar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@msheppar msheppar changed the title Test java/net/Inet6Address/serialize/Inet6AddressSerializationTest.java fails due to dynamic reconfigurations of network interface during test JDK-8263256: Test java/net/Inet6Address/serialize/Inet6AddressSerializationTest.java fails due to dynamic reconfigurations of network interface during test Dec 6, 2023
@openjdk
Copy link

openjdk bot commented Dec 6, 2023

@msheppar The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added net net-dev@openjdk.org rfr Pull request is ready for review labels Dec 6, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 6, 2023

Webrevs

if (dName != null && dName.contains("Teredo")) {
continue;
}
}
// skipp awdl and llw interfaces on macosx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Mark, this and a few other places have a typo for the word "skip"

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks OK to me. Please update the copyright year on the test file.

@openjdk
Copy link

openjdk bot commented Dec 7, 2023

@msheppar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263256: Test java/net/Inet6Address/serialize/Inet6AddressSerializationTest.java fails due to dynamic reconfigurations of network interface during test

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

  • 49fff01: 8211238: @deprecated JFR event
  • 656b446: 8320969: Shenandoah: Enforce stable number of GC workers
  • 9a87e52: 8320538: Obsolete CSS styles in collection framework doc-file
  • 03c4595: 8321164: javac with annotation processor throws AssertionError: Filling jrt:/... during JarFileObject[/...]
  • 632a3c5: 8305825: getBounds API returns wrong value resulting in multiple Regression Test Failures on Ubuntu 23.04
  • 75a7c19: 8315827: Kitchensink.java and RenaissanceStressTest.java time out with jvmti module errors
  • 91ffdfb: 8320365: IPPPrintService.getAttributes() causes blanket re-initialisation
  • 50baaf4: 8321013: Parallel: Refactor ObjectStartArray
  • afb8964: 8320443: [macos] Test java/awt/print/PrinterJob/PrinterDevice.java fails on macOS
  • 82796bd: 8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters
  • ... and 22 more: https://git.openjdk.org/jdk/compare/430564cf8882e9acf86a193eb76030c6254f798c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 7, 2023
…va fails due to dynamic reconfigurations of network interface during test: update to copyright
…va fails due to dynamic reconfigurations of network interface during test correct typo skipp --> skip
@msheppar
Copy link
Author

msheppar commented Dec 7, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Dec 7, 2023

Going to push as commit 0048f1d.
Since your change was applied there have been 32 commits pushed to the master branch:

  • 49fff01: 8211238: @deprecated JFR event
  • 656b446: 8320969: Shenandoah: Enforce stable number of GC workers
  • 9a87e52: 8320538: Obsolete CSS styles in collection framework doc-file
  • 03c4595: 8321164: javac with annotation processor throws AssertionError: Filling jrt:/... during JarFileObject[/...]
  • 632a3c5: 8305825: getBounds API returns wrong value resulting in multiple Regression Test Failures on Ubuntu 23.04
  • 75a7c19: 8315827: Kitchensink.java and RenaissanceStressTest.java time out with jvmti module errors
  • 91ffdfb: 8320365: IPPPrintService.getAttributes() causes blanket re-initialisation
  • 50baaf4: 8321013: Parallel: Refactor ObjectStartArray
  • afb8964: 8320443: [macos] Test java/awt/print/PrinterJob/PrinterDevice.java fails on macOS
  • 82796bd: 8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters
  • ... and 22 more: https://git.openjdk.org/jdk/compare/430564cf8882e9acf86a193eb76030c6254f798c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 7, 2023
@openjdk openjdk bot closed this Dec 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 7, 2023
@openjdk
Copy link

openjdk bot commented Dec 7, 2023

@msheppar Pushed as commit 0048f1d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Copy link
Member

@dfuch dfuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix @msheppar !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
3 participants