-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8320597: RSA signature verification fails on signed data that does not encode params correctly #17002
Conversation
👋 Welcome back weijun! A progress list of the required criteria for merging this PR into |
Webrevs
|
/** | ||
* @test | ||
* @bug 8320597 | ||
* @summary RSA signature verification fails on signed data that does not encode params correctly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The summary seems to contradict the check on line 52? Maybe: Verify RSA signature with omitted digest params (should be encoded as NULL) for backward compatibility?
Rest looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this is the title of the bug which described what was wrong, and I often simply copy this as the summary of a bug. You mean here I should emphasis what is corrected and the updated behavior?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wangweij This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 77 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Thanks~
/integrate |
Going to push as commit 11e4a92.
Your commit was automatically rebased without conflicts. |
Add a fallback if an RSA signature was generated without the NULL params in its encoded hash.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17002/head:pull/17002
$ git checkout pull/17002
Update a local copy of the PR:
$ git checkout pull/17002
$ git pull https://git.openjdk.org/jdk.git pull/17002/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 17002
View PR using the GUI difftool:
$ git pr show -t 17002
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17002.diff
Webrev
Link to Webrev Comment