Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321409: Console read line with zero out should zero out underlying buffer in JLine (redux) #17004

Closed

Conversation

naotoj
Copy link
Member

@naotoj naotoj commented Dec 6, 2023

This is an additional fix to JDK-8321131, where more clearing is required in JLine.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8321409: Console read line with zero out should zero out underlying buffer in JLine (redux) (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17004/head:pull/17004
$ git checkout pull/17004

Update a local copy of the PR:
$ git checkout pull/17004
$ git pull https://git.openjdk.org/jdk.git pull/17004/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17004

View PR using the GUI difftool:
$ git pr show -t 17004

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17004.diff

Webrev

Link to Webrev Comment

@naotoj
Copy link
Member Author

naotoj commented Dec 6, 2023

/label add core-libs

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 6, 2023

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review core-libs core-libs-dev@openjdk.org labels Dec 6, 2023
@openjdk
Copy link

openjdk bot commented Dec 6, 2023

@naotoj
The core-libs label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Dec 6, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 7, 2023

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321409: Console read line with zero out should zero out underlying buffer in JLine (redux)

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 7, 2023
@naotoj
Copy link
Member Author

naotoj commented Dec 7, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Dec 7, 2023

Going to push as commit 4ed38f5.
Since your change was applied there have been 30 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 7, 2023
@openjdk openjdk bot closed this Dec 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 7, 2023
@openjdk
Copy link

openjdk bot commented Dec 7, 2023

@naotoj Pushed as commit 4ed38f5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants