Skip to content

8311218: fatal error: stuck in JvmtiVTMSTransitionDisabler::VTMS_transition_disable #17011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

8311218: fatal error: stuck in JvmtiVTMSTransitionDisabler::VTMS_transition_disable #17011

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d85d5ca
8311218: fatal error: stuck in JvmtiVTMSTransitionDisabler::VTMS_tran…
sspitsyn Dec 7, 2023
1b56eea
add new test SuspendWithInterruptLock.java
sspitsyn Dec 7, 2023
64426f8
added @summary to new test SuspendWithInterruptLock.java
sspitsyn Dec 7, 2023
ccba940
Resolved merge conflict in VirtualThread.java
sspitsyn Dec 7, 2023
18f1752
review: (1) rename notifyJvmti method; (2) add try-final statements t…
sspitsyn Dec 8, 2023
4e5f644
review: 1) replace CriticalLock with DisableSuspend; 2) minor tweaks
sspitsyn Dec 14, 2023
ad99042
review: moved notifyJvmtiDisableSuspend(true) out of try-block
sspitsyn Dec 14, 2023
917dc72
review: moved a couple of comments out of try blocks
sspitsyn Dec 14, 2023
6f8cdf0
review: improve an assert message
sspitsyn Dec 15, 2023
9ba94c3
Merge
sspitsyn Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/java.base/share/classes/java/lang/VirtualThread.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,8 +742,8 @@ void unpark() {
submitRunContinuation();
}
} else if ((s == PINNED) || (s == TIMED_PINNED)) {
notifyJvmtiDisableSuspend(true);
try {
notifyJvmtiDisableSuspend(true);
// unpark carrier thread when pinned
synchronized (carrierThreadAccessLock()) {
Thread carrier = carrierThread;
Expand Down Expand Up @@ -849,8 +849,8 @@ boolean joinNanos(long nanos) throws InterruptedException {
public void interrupt() {
if (Thread.currentThread() != this) {
checkAccess();
notifyJvmtiDisableSuspend(true);
try {
notifyJvmtiDisableSuspend(true);
synchronized (interruptLock) {
interrupted = true;
Interruptible b = nioBlocker;
Expand Down Expand Up @@ -882,8 +882,8 @@ boolean getAndClearInterrupt() {
assert Thread.currentThread() == this;
boolean oldValue = interrupted;
if (oldValue) {
notifyJvmtiDisableSuspend(true);
try {
notifyJvmtiDisableSuspend(true);
synchronized (interruptLock) {
interrupted = false;
carrierThread.clearInterrupt();
Expand Down Expand Up @@ -913,8 +913,8 @@ Thread.State threadState() {
// runnable, not mounted
return Thread.State.RUNNABLE;
case RUNNING:
notifyJvmtiDisableSuspend(true);
try {
notifyJvmtiDisableSuspend(true);
// if mounted then return state of carrier thread
synchronized (carrierThreadAccessLock()) {
Thread carrierThread = this.carrierThread;
Expand Down Expand Up @@ -1038,8 +1038,8 @@ public String toString() {
sb.append("]/");
Thread carrier = carrierThread;
if (carrier != null) {
notifyJvmtiDisableSuspend(true);
try {
notifyJvmtiDisableSuspend(true);
// include the carrier thread state and name when mounted
synchronized (carrierThreadAccessLock()) {
carrier = carrierThread;
Expand Down