8321422: Test gc/g1/pinnedobjs/TestPinnedObjectTypes.java times out after completion

[tschatzl]

Hi all,

please review this change that disables core file creation for the subtests of this test that check for assertion failure. Core dump creation can make the whole test time out.

----------System.out:(54/8466)----------
Command line:... -XX:+UseG1GC -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI -Xbootclasspath/a:. -Xmx32M -Xmn16M -Xlog:gc gc.g1.pinnedobjs.TestObjectPin Object ]
[2023-12-05T23:30:37.930237Z] Gathering output for process 98165
[0.066s][info][gc] Using G1
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  Internal Error (/open/src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp:268), pid=98165, tid=6403
#  assert(obj->is_typeArray()) failed: must be typeArray
#[...]
# If you would like to submit a bug report, please visit:
#   https://bugreport.java.com/bugreport/crash.jsp
#

[2023-12-05T23:35:20.308715Z] Waiting for completion for process 98165
[2023-12-05T23:35:20.632162Z] Waiting for completion finished for process 98165

Notice the 5 min delay from the Gathering output for process to the Waiting for completion finished message. This repeats for the second test, triggering the timeout.

Testing: failing test

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8321422: Test gc/g1/pinnedobjs/TestPinnedObjectTypes.java times out after completion (Bug - P2)

Reviewers

• Ivan Walulya (@walulyai - Reviewer)
• Albert Mingkun Yang (@albertnetymk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17013/head:pull/17013
$ git checkout pull/17013

Update a local copy of the PR:
$ git checkout pull/17013
$ git pull https://git.openjdk.org/jdk.git pull/17013/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17013

View PR using the GUI difftool:
$ git pr show -t 17013

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17013.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (73202610)
• 00: Full (1efd09b6)

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321422: Test gc/g1/pinnedobjs/TestPinnedObjectTypes.java times out after completion

Reviewed-by: iwalulya, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 55 new commits pushed to the master branch:

• 6f48240: 8321729: Remove 'orb' field in RMIConnector
• e1fd663: 8311306: Test com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java failed: out of expected range
• d5214a4: 8321814: G1: Remove unused G1RemSetScanState::_collection_set_iter_state
• 2611a49: 8321287: Remove unused enum style in Prefetch
• b8c0b2f: 8321594: NativeThreadSet should use placeholder for virtual threads
• 973bcda: 8321631: Fix comments in access.hpp
• 6359b4e: 8318217: RISC-V: C2 VectorizedHashCode
• ce4b257: 8320886: Unsafe_SetMemory0 is not guarded
• b270f30: 8318629: G1: Refine code a bit in G1RemSetTrackingPolicy::update_at_allocate
• 486594d: 8316657: Support whitebox testing in microbenchmarks
• ... and 45 more: https://git.openjdk.org/jdk/compare/632a3c56e0626b4c4f79c8cb3d2ae312668d63fc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tschatzl]

Thanks @walulyai @albertnetymk for your reviews

/integrate

[openjdk]

Going to push as commit 7d90396.
Since your change was applied there have been 55 commits pushed to the master branch:

• 6f48240: 8321729: Remove 'orb' field in RMIConnector
• e1fd663: 8311306: Test com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java failed: out of expected range
• d5214a4: 8321814: G1: Remove unused G1RemSetScanState::_collection_set_iter_state
• 2611a49: 8321287: Remove unused enum style in Prefetch
• b8c0b2f: 8321594: NativeThreadSet should use placeholder for virtual threads
• 973bcda: 8321631: Fix comments in access.hpp
• 6359b4e: 8318217: RISC-V: C2 VectorizedHashCode
• ce4b257: 8320886: Unsafe_SetMemory0 is not guarded
• b270f30: 8318629: G1: Refine code a bit in G1RemSetTrackingPolicy::update_at_allocate
• 486594d: 8316657: Support whitebox testing in microbenchmarks
• ... and 45 more: https://git.openjdk.org/jdk/compare/632a3c56e0626b4c4f79c8cb3d2ae312668d63fc...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit 7d90396.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[tschatzl]

/backport jdk22

[openjdk]

@tschatzl the backport was successfully created on the branch backport-tschatzl-7d903964 in my personal fork of openjdk/jdk22. To create a pull request with this backport targeting openjdk/jdk22:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 7d903964 from the openjdk/jdk repository.

The commit being backported was authored by Thomas Schatzl on 12 Dec 2023 and was reviewed by Ivan Walulya and Albert Mingkun Yang.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk22:

$ git fetch https://github.com/openjdk-bots/jdk22.git backport-tschatzl-7d903964:backport-tschatzl-7d903964
$ git checkout backport-tschatzl-7d903964
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk22.git backport-tschatzl-7d903964